linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [syzbot] WARNING in __i2c_transfer
@ 2021-03-12  7:47 syzbot
  2021-03-12  9:13 ` Wolfram Sang
  2021-03-12 10:09 ` syzbot
  0 siblings, 2 replies; 4+ messages in thread
From: syzbot @ 2021-03-12  7:47 UTC (permalink / raw)
  To: linux-i2c, linux-kernel, syzkaller-bugs, wsa

Hello,

syzbot found the following issue on:

HEAD commit:    28806e4d Merge tag 'media/v5.12-2' of git://git.kernel.org..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=11192342d00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=6bcf96204c1b8e77
dashboard link: https://syzkaller.appspot.com/bug?extid=ffb0b3ffa6cfbc7d7b3f
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1083223ad00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=14345f0ad00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+ffb0b3ffa6cfbc7d7b3f@syzkaller.appspotmail.com

------------[ cut here ]------------
WARNING: CPU: 1 PID: 8406 at drivers/i2c/i2c-core-base.c:2021 __i2c_transfer+0xa87/0x17d0 drivers/i2c/i2c-core-base.c:2021
Modules linked in:
CPU: 0 PID: 8406 Comm: syz-executor613 Not tainted 5.12.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:__i2c_transfer+0xa87/0x17d0 drivers/i2c/i2c-core-base.c:2021
Code: 0f 94 c7 31 ff 44 89 fe e8 96 ba c2 fb 45 84 ff 0f 84 b3 fc ff ff e8 d8 b3 c2 fb e8 b2 5a 4f fb e9 a4 fc ff ff e8 c9 b3 c2 fb <0f> 0b 41 bc ea ff ff ff e9 2b fd ff ff e8 b7 b3 c2 fb 44 89 ee bf
RSP: 0018:ffffc900018cfd48 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 0000000000000010 RCX: 0000000000000000
RDX: ffff88801e4e5340 RSI: ffffffff85b0ea97 RDI: 0000000000000003
RBP: ffff888020870b58 R08: 0000000000000000 R09: ffffffff8faa792f
R10: ffffffff85b0e048 R11: 1ffffffff1ed6964 R12: 0000000000000010
R13: 0000000000000000 R14: ffff888020870b78 R15: 0000000000000000
FS:  000000000226f300(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fcccc5096c0 CR3: 0000000012e13000 CR4: 0000000000350ef0
Call Trace:
 i2c_transfer+0x1e6/0x3e0 drivers/i2c/i2c-core-base.c:2112
 i2cdev_ioctl_rdwr+0x583/0x6a0 drivers/i2c/i2c-dev.c:297
 i2cdev_ioctl+0x46c/0x780 drivers/i2c/i2c-dev.c:453
 vfs_ioctl fs/ioctl.c:48 [inline]
 __do_sys_ioctl fs/ioctl.c:753 [inline]
 __se_sys_ioctl fs/ioctl.c:739 [inline]
 __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:739
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x443469
Code: 28 c3 e8 2a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffb0c53048 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00000000004004a0 RCX: 0000000000443469
RDX: 0000000020004480 RSI: 0000000000000707 RDI: 0000000000000003
RBP: 0000000000403010 R08: 00232d6332692f76 R09: 00000000004004a0
R10: 000000000000001f R11: 0000000000000246 R12: 00000000004030a0
R13: 0000000000000000 R14: 00000000004b1018 R15: 00000000004004a0


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [syzbot] WARNING in __i2c_transfer
  2021-03-12  7:47 [syzbot] WARNING in __i2c_transfer syzbot
@ 2021-03-12  9:13 ` Wolfram Sang
  2021-03-12 10:09 ` syzbot
  1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2021-03-12  9:13 UTC (permalink / raw)
  To: syzbot; +Cc: linux-i2c, linux-kernel, syzkaller-bugs

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

On Thu, Mar 11, 2021 at 11:47:17PM -0800, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    28806e4d Merge tag 'media/v5.12-2' of git://git.kernel.org..
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=11192342d00000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=6bcf96204c1b8e77
> dashboard link: https://syzkaller.appspot.com/bug?extid=ffb0b3ffa6cfbc7d7b3f
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1083223ad00000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=14345f0ad00000
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+ffb0b3ffa6cfbc7d7b3f@syzkaller.appspotmail.com
> 
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 8406 at drivers/i2c/i2c-core-base.c:2021 __i2c_transfer+0xa87/0x17d0 drivers/i2c/i2c-core-base.c:2021

Yes, it can be argued that userspace should not be able to trigger a
WARNING. For in-kernel users, the WARN is really helpful, though. I will
add sanity checks much earlier to i2c-dev.c which will not be that
noisy.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [syzbot] WARNING in __i2c_transfer
  2021-03-12  7:47 [syzbot] WARNING in __i2c_transfer syzbot
  2021-03-12  9:13 ` Wolfram Sang
@ 2021-03-12 10:09 ` syzbot
  2021-03-12 11:46   ` Wolfram Sang
  1 sibling, 1 reply; 4+ messages in thread
From: syzbot @ 2021-03-12 10:09 UTC (permalink / raw)
  To: dwlsalmeida, linux-i2c, linux-kernel, linux-media, mchehab+huawei,
	mchehab, paskripkin, syzkaller-bugs, wsa

syzbot has bisected this issue to:

commit f90cf6079bf67988f8b1ad1ade70fc89d0080905
Author: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
Date:   Fri Aug 21 12:58:47 2020 +0000

    media: vidtv: add a bridge driver

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=1136cf66d00000
start commit:   28806e4d Merge tag 'media/v5.12-2' of git://git.kernel.org..
git tree:       upstream
final oops:     https://syzkaller.appspot.com/x/report.txt?x=1336cf66d00000
console output: https://syzkaller.appspot.com/x/log.txt?x=1536cf66d00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=6bcf96204c1b8e77
dashboard link: https://syzkaller.appspot.com/bug?extid=ffb0b3ffa6cfbc7d7b3f
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1083223ad00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=14345f0ad00000

Reported-by: syzbot+ffb0b3ffa6cfbc7d7b3f@syzkaller.appspotmail.com
Fixes: f90cf6079bf6 ("media: vidtv: add a bridge driver")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [syzbot] WARNING in __i2c_transfer
  2021-03-12 10:09 ` syzbot
@ 2021-03-12 11:46   ` Wolfram Sang
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2021-03-12 11:46 UTC (permalink / raw)
  To: syzbot
  Cc: dwlsalmeida, linux-i2c, linux-kernel, linux-media, mchehab+huawei,
	mchehab, paskripkin, syzkaller-bugs

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

On Fri, Mar 12, 2021 at 02:09:08AM -0800, syzbot wrote:
> syzbot has bisected this issue to:
> 
> commit f90cf6079bf67988f8b1ad1ade70fc89d0080905
> Author: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
> Date:   Fri Aug 21 12:58:47 2020 +0000
> 
>     media: vidtv: add a bridge driver

This is a false positive.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-12 11:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-12  7:47 [syzbot] WARNING in __i2c_transfer syzbot
2021-03-12  9:13 ` Wolfram Sang
2021-03-12 10:09 ` syzbot
2021-03-12 11:46   ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).