From: Wolfram Sang <wsa@kernel.org>
To: Klaus Kudielka <klaus.kudielka@gmail.com>
Cc: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>,
linux-i2c@vger.kernel.org
Subject: Re: Linux 5.11: i2c: Confusing error message
Date: Mon, 15 Mar 2021 11:10:14 +0100 [thread overview]
Message-ID: <20210315101014.GA1182@ninjato> (raw)
In-Reply-To: <1787a9ee-efae-7e4b-9e6f-d4bf532c6b63@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]
Hello Klaus,
On Mon, Mar 15, 2021 at 07:58:21AM +0100, Klaus Kudielka wrote:
Thanks for the report! I am CCing the I2C list, please add it next time,
too.
> Hello,
>
> I recently upgraded my Turris Omnia (Marvell Armada 385) to 5.11, and now
> get the following error message during boot:
>
> i2c i2c-0: Not using recovery: no recover_bus() found
>
> As far as I understand the situation:
>
> * After commit 9c7cae2427715502227f823364a6a77828fdf3ea mv64xxx-i2c
> unconditionally sets bus_recovery_info and bus_recovery_info->pinctrl
> * The i2c bus node in the turris-omnia DTS does *not* have a pinctrl
> state "gpio" or "recovery" (like any other Marvell Armada board, AFAICS)
> * i2c_gpio_init_recovery() throws a debug message "no gpio or recovery
> state found for GPIO recovery", which (under normal circumstances)
> users won't see
> * After i2c_gpio_init_recovery() returns, i2c_init_recovery() throws
> above-mentioned error message
>
> Is this the intended behaviour?
> Personally, I believe an "error" message is quite strong for this common
> scenario, and a bit misleading.
You are right. The case that a pinctrl is provided but not the necessary
states for recovery has been overlooked so far.
I will think of something right now.
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next parent reply other threads:[~2021-03-15 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1787a9ee-efae-7e4b-9e6f-d4bf532c6b63@gmail.com>
2021-03-15 10:10 ` Wolfram Sang [this message]
2021-03-15 20:18 ` Linux 5.11: i2c: Confusing error message Mark Tomlinson
2021-03-15 20:39 ` wsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315101014.GA1182@ninjato \
--to=wsa@kernel.org \
--cc=klaus.kudielka@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mark.tomlinson@alliedtelesis.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).