From: Lee Jones <lee.jones@linaro.org>
To: "Jonas Mark (BT-FIR/ENG1-Grb)" <Mark.Jonas@de.bosch.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"Adam.Thomson.Opensource@diasemi.com"
<Adam.Thomson.Opensource@diasemi.com>,
"stwiss.opensource@diasemi.com" <stwiss.opensource@diasemi.com>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
"RUAN Tingquan (BT-FIR/ENG1-Zhu)" <Tingquan.Ruan@cn.bosch.com>,
"Streidl Hubert (BT-FIR/ENG1-Grb)" <Hubert.Streidl@de.bosch.com>,
Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH v5] mfd: da9063: Support SMBus and I2C mode
Date: Tue, 16 Mar 2021 09:54:40 +0000 [thread overview]
Message-ID: <20210316095440.GC701493@dell> (raw)
In-Reply-To: <4dbc130e769547508be811e61a348255@de.bosch.com>
On Tue, 16 Mar 2021, Jonas Mark (BT-FIR/ENG1-Grb) wrote:
> Hi Lee,
>
> > Code looks good to me now, thanks.
> >
> > However, this doesn't look like it would pass checkpatch.
> >
> > Have you tried to build with W=1 and checkpatch?
>
> Yes, we used checkpatch.pl.
>
> $ ./scripts/checkpatch.pl 0001-mfd-da9063-Support-SMBus-and-I2C-mode.v5
> total: 0 errors, 0 warnings, 25 lines checked
>
> 0001-mfd-da9063-Support-SMBus-and-I2C-mode.v5 has no obvious style problems and is ready for submission.
>
> Using the option --strict we get a check hint that the broken line of the regmap_clear_bits() is not aligned. We tried but were not able to make the tool happy. This matches our experience with this check hint and previous patches.
>
> Also compiling Linux 5.10.14 with our patch and W=1 does not yield a warning.
FYI, you should be using -next for upstream development.
> $ make W=1
> CALL scripts/checksyscalls.sh
> CALL scripts/atomic/check-atomics.sh
> CHK include/generated/compile.h
> CC [M] drivers/mfd/da9063-i2c.o
> LD [M] drivers/mfd/da9063.o
> Kernel: arch/arm/boot/Image is ready
> Kernel: arch/arm/boot/zImage is ready
> MODPOST Module.symvers
> LD [M] drivers/mfd/da9063.ko
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-03-16 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 16:09 [PATCH v5] mfd: da9063: Support SMBus and I2C mode Mark Jonas
2021-03-15 18:31 ` Wolfram Sang
2021-03-16 7:21 ` Lee Jones
2021-03-16 8:23 ` Jonas Mark (BT-FIR/ENG1-Grb)
2021-03-16 9:54 ` Lee Jones
2021-03-16 9:54 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316095440.GC701493@dell \
--to=lee.jones@linaro.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Hubert.Streidl@de.bosch.com \
--cc=Mark.Jonas@de.bosch.com \
--cc=Tingquan.Ruan@cn.bosch.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).