From: Wolfram Sang <wsa@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Sanket Goswami <Sanket.Goswami@amd.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next v2] i2c: designware: Fix return value check in navi_amd_register_client()
Date: Thu, 8 Apr 2021 22:48:22 +0200 [thread overview]
Message-ID: <20210408204822.GC1900@kunai> (raw)
In-Reply-To: <20210407031137.2750993-1-weiyongjun1@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
On Wed, Apr 07, 2021 at 03:11:37AM +0000, Wei Yongjun wrote:
> In case of error, the function i2c_new_client_device() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Fixes: 17631e8ca2d3 ("i2c: designware: Add driver support for AMD NAVI GPU")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-04-08 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 3:11 [PATCH -next v2] i2c: designware: Fix return value check in navi_amd_register_client() Wei Yongjun
2021-04-07 11:11 ` Jarkko Nikula
2021-04-07 11:55 ` Goswami, Sanket
2021-04-08 20:48 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408204822.GC1900@kunai \
--to=wsa@kernel.org \
--cc=Sanket.Goswami@amd.com \
--cc=hulkci@huawei.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).