From: Andreas Kemnade <andreas@kemnade.info>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Rob Herring <robh+dt@kernel.org>, <linux-omap@vger.kernel.org>,
<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v2] dt-bindings: i2c: Move i2c-omap.txt to YAML format
Date: Fri, 7 May 2021 16:36:02 +0200 [thread overview]
Message-ID: <20210507163602.219894f4@aktux> (raw)
In-Reply-To: <429a740a-c2b9-1cf8-ed2b-0fb7b1bea422@ti.com>
On Fri, 7 May 2021 19:45:45 +0530
Vignesh Raghavendra <vigneshr@ti.com> wrote:
> On 5/7/21 12:24 PM, Grygorii Strashko wrote:
> >
> >
> > On 06/05/2021 17:00, Vignesh Raghavendra wrote:
> >> Convert i2c-omap.txt to YAML schema for better checks and documentation.
> >>
> >> Following properties were used in DT but were not documented in txt
> >> bindings and has been included in YAML schema:
> >> 1. Include ti,am4372-i2c compatible
> >> 2. Include dmas property used in few OMAP dts files
> >
> > The DMA is not supported by i2c-omap driver, so wouldn't be better to
> > just drop dmas from DTBs to avoid confusions?
> > It can be added later.
> >
>
> Will do.. I will also send patches dropping dmas from dts that currently
> have them populated.
>
hmm, we have
- DO attempt to make bindings complete even if a driver doesn't support some
features. For example, if a device has an interrupt, then include the
'interrupts' property even if the driver is only polled mode.
in Documentation/devicetree/bindings/writing-bindings.rst
Shouln't the dma stay there if the hardware supports it? Devicetree
should describe the hardware not the driver if I understood things
right.
Regards,
Andreas
next prev parent reply other threads:[~2021-05-07 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 14:00 [PATCH v2] dt-bindings: i2c: Move i2c-omap.txt to YAML format Vignesh Raghavendra
2021-05-06 18:55 ` Nishanth Menon
2021-05-07 6:54 ` Grygorii Strashko
2021-05-07 14:15 ` Vignesh Raghavendra
2021-05-07 14:36 ` Andreas Kemnade [this message]
2021-05-07 17:24 ` Grygorii Strashko
2021-05-07 21:43 ` Rob Herring
2021-05-07 22:02 ` Wolfram Sang
2021-05-10 11:06 ` Vignesh Raghavendra
2021-05-26 6:52 ` Tony Lindgren
2021-05-07 21:19 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507163602.219894f4@aktux \
--to=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).