From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD2CC433B4 for ; Fri, 21 May 2021 10:06:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70CB661019 for ; Fri, 21 May 2021 10:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233340AbhEUKHu (ORCPT ); Fri, 21 May 2021 06:07:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:44528 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231995AbhEUKHo (ORCPT ); Fri, 21 May 2021 06:07:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 09393AAA6; Fri, 21 May 2021 10:06:20 +0000 (UTC) Date: Fri, 21 May 2021 12:06:19 +0200 From: Jean Delvare To: Lee Jones Cc: linux-kernel@vger.kernel.org, Rudolf Marek , linux-i2c@vger.kernel.org Subject: Re: [PATCH 03/16] i2c: busses: i2c-ali1563: File headers are not good candidates for kernel-doc Message-ID: <20210521120619.503cb7d9@endymion> In-Reply-To: <20210520190105.3772683-4-lee.jones@linaro.org> References: <20210520190105.3772683-1-lee.jones@linaro.org> <20210520190105.3772683-4-lee.jones@linaro.org> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Lee, On Thu, 20 May 2021 20:00:52 +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/i2c/busses/i2c-ali1563.c:24: warning: expecting prototype for i2c(). Prototype was for ALI1563_MAX_TIMEOUT() instead Thanks for taking care of the warnings. I agree that a clean W=1 build would be very nice to have. > Cc: Jean Delvare > Cc: Rudolf Marek > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/i2c/busses/i2c-ali1563.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c > index 4d12e3da12f0d..55a9e93fbfeb5 100644 > --- a/drivers/i2c/busses/i2c-ali1563.c > +++ b/drivers/i2c/busses/i2c-ali1563.c > @@ -1,5 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > -/** > +/* > * i2c-ali1563.c - i2c driver for the ALi 1563 Southbridge > * > * Copyright (C) 2004 Patrick Mochel Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support