From: Jean Delvare <jdelvare@suse.de>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: wsa@kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [i2c-tools PATCH] tools: i2cbusses: Handle bus names like /dev/i2c-0
Date: Wed, 26 May 2021 09:39:18 +0200 [thread overview]
Message-ID: <20210526093918.73c40482@endymion> (raw)
In-Reply-To: <20210525090612.26157-1-chris.packham@alliedtelesis.co.nz>
Hi Chris,
On Tue, 25 May 2021 21:06:12 +1200, Chris Packham wrote:
> File based tab completion means it's easy to do something like
> i2cdump /dev/i2c-0 0x52. Accept this method of specifying the i2c bus
> device.
I can't really see the value of this change, sorry. You want to use a
longer parameter so you can tab-complete it. The original parameter was
a 1- or 2-digit number, which is faster to type than /d<tab>i2<tab>.
Plus if you have multiple i2c buses, tab completion can't guess which
one you want anyway, so you'll have to type the bus number eventually.
So, what do we actually win here?
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2021-05-26 7:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 9:06 [i2c-tools PATCH] tools: i2cbusses: Handle bus names like /dev/i2c-0 Chris Packham
2021-05-26 7:39 ` Jean Delvare [this message]
2021-05-26 21:23 ` Chris Packham
2021-06-02 7:25 ` Jean Delvare
2021-06-03 22:57 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526093918.73c40482@endymion \
--to=jdelvare@suse.de \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).