From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@kernel.org>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: ali1535: mention that the device should not be disabled
Date: Thu, 1 Jul 2021 14:14:18 +0200 [thread overview]
Message-ID: <20210701141418.0b51d668@endymion> (raw)
In-Reply-To: <20210625151758.12180-1-wsa@kernel.org>
On Fri, 25 Jun 2021 17:17:58 +0200, Wolfram Sang wrote:
> The comment from the i801 driver is valid here, too, so copy it.
>
> Reported-by: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: Wolfram Sang <wsa@kernel.org>
> ---
> drivers/i2c/busses/i2c-ali1535.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
> index fb93152845f4..ee83c4581bce 100644
> --- a/drivers/i2c/busses/i2c-ali1535.c
> +++ b/drivers/i2c/busses/i2c-ali1535.c
> @@ -508,6 +508,11 @@ static void ali1535_remove(struct pci_dev *dev)
> {
> i2c_del_adapter(&ali1535_adapter);
> release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
> +
> + /*
> + * do not call pci_disable_device(dev) since it can cause hard hangs on
> + * some systems during power-off
> + */
> }
>
> static struct pci_driver ali1535_driver = {
Can't hurt.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2021-07-01 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 15:17 [PATCH] i2c: ali1535: mention that the device should not be disabled Wolfram Sang
2021-07-01 12:14 ` Jean Delvare [this message]
2021-07-02 7:53 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210701141418.0b51d668@endymion \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).