From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC684C07E95 for ; Tue, 13 Jul 2021 08:21:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C575D611C0 for ; Tue, 13 Jul 2021 08:21:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234157AbhGMIYW (ORCPT ); Tue, 13 Jul 2021 04:24:22 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:55444 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234395AbhGMIYW (ORCPT ); Tue, 13 Jul 2021 04:24:22 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 30B0320060; Tue, 13 Jul 2021 08:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626164492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8SQ6xeafmlUxItSlrb6MoG4XnTMFJZjK7RgmSOF8Nt4=; b=MlMMzbsRAxDD5DSJBrCZ41FCcVz7NbQcqC937Ep81mtmqGwjd1sylaOBsXfL0fE8tvkeRd 7ThE+wTvAc/nirfkdMXO/6wCEKnTmXKQ0VpzshHOQ+zYkWaMbqYqRNHdL+NjUPksKsPffs g3WLeWmCv65tTb1FbE2OU3m3dhaZihU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626164492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8SQ6xeafmlUxItSlrb6MoG4XnTMFJZjK7RgmSOF8Nt4=; b=Vc7VDatqHv6Z8wpLVm67xaV8ab9q1YYkHMGtlJmsFPX0yLDF9V5IbdguYeZtrXxYnxiIfP GVyI10lLe7i6CvAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EAC7413BC9; Tue, 13 Jul 2021 08:21:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NJQTNgtN7WCMRAAAMHmgww (envelope-from ); Tue, 13 Jul 2021 08:21:31 +0000 Date: Tue, 13 Jul 2021 10:21:30 +0200 From: Jean Delvare To: Wolfram Sang Cc: Linux I2C Subject: Re: [PATCH 0/7] Rework block read support among i2cget and i2cdump Message-ID: <20210713102130.7dd5851b@endymion> In-Reply-To: References: <20210608172338.0cf520a1@endymion> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Wolfram, On Sun, 27 Jun 2021 12:27:40 +0200, Wolfram Sang wrote: > > The idea would be to get the first 6 patches in the upcoming i2c-tools > > v4.3, and apply the 7th patch "later" (either immediately after that > > release, or some time later, I'm not sure). > > So, my tests so far went nicely and looking more at the patches didn't > reveal any major discussion point. So: > > Reviewed-by: Wolfram Sang > Tested-by: Wolfram Sang > > I'd vote also for an early removal. The code cleanup is too nice and > i2cget is, in deed, the better place for mode 's'. Thanks for the review and testing, very much appreciated. I have committed the first 6 patches, with cosmetic fixes after a last self-review. With this, we are ready to release i2c-tools 4.3. -- Jean Delvare SUSE L3 Support