From: Oleksij Rempel <o.rempel@pengutronix.de>
To: David Heidelberg <david@ixit.cz>
Cc: Oleksij Rempel <linux@rempel-privat.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Anson Huang <Anson.Huang@nxp.com>,
~okias/devicetree@lists.sr.ht, Rob Herring <robh@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz
Date: Mon, 1 Nov 2021 08:20:33 +0100 [thread overview]
Message-ID: <20211101072033.GG20681@pengutronix.de> (raw)
In-Reply-To: <20211029141134.66170-1-david@ixit.cz>
On Fri, Oct 29, 2021 at 04:11:33PM +0200, David Heidelberg wrote:
> clock-frequency is only restricted by the upper limit of 400 kHz.
>
> Found with:
> $ DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-imx.yaml make dtbs_check
> ...
> arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: i2c@30a20000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
> From schema: linux/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> ...
>
> Fixes: 4bdc44347299 ("dt-bindings: i2c: Convert imx i2c to json-schema")
> Signed-off-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> index 3592d49235e0..c167958ae2a9 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> @@ -57,7 +57,9 @@ properties:
> const: ipg
>
> clock-frequency:
> - enum: [ 100000, 400000 ]
> + minimum: 1
> + default: 100000
> + maximum: 400000
>
> dmas:
> items:
> --
> 2.33.0
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-11-01 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 14:11 [PATCH] dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz David Heidelberg
2021-11-01 7:20 ` Oleksij Rempel [this message]
2021-11-08 20:58 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101072033.GG20681@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=Anson.Huang@nxp.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).