From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C65C433F5 for ; Mon, 1 Nov 2021 07:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2823D61078 for ; Mon, 1 Nov 2021 07:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbhKAHXW (ORCPT ); Mon, 1 Nov 2021 03:23:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbhKAHXV (ORCPT ); Mon, 1 Nov 2021 03:23:21 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73421C061714 for ; Mon, 1 Nov 2021 00:20:48 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhRcT-0001Xl-0S; Mon, 01 Nov 2021 08:20:37 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mhRcP-00016X-2V; Mon, 01 Nov 2021 08:20:33 +0100 Date: Mon, 1 Nov 2021 08:20:33 +0100 From: Oleksij Rempel To: David Heidelberg Cc: Oleksij Rempel , Pengutronix Kernel Team , Rob Herring , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Anson Huang , ~okias/devicetree@lists.sr.ht, Rob Herring , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz Message-ID: <20211101072033.GG20681@pengutronix.de> References: <20211029141134.66170-1-david@ixit.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211029141134.66170-1-david@ixit.cz> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:19:52 up 256 days, 10:43, 105 users, load average: 0.01, 0.10, 0.14 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i2c@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Fri, Oct 29, 2021 at 04:11:33PM +0200, David Heidelberg wrote: > clock-frequency is only restricted by the upper limit of 400 kHz. > > Found with: > $ DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-imx.yaml make dtbs_check > ... > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: i2c@30a20000: clock-frequency:0:0: 387000 is not one of [100000, 400000] > From schema: linux/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > ... > > Fixes: 4bdc44347299 ("dt-bindings: i2c: Convert imx i2c to json-schema") > Signed-off-by: David Heidelberg Reviewed-by: Oleksij Rempel Thank you! > --- > Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > index 3592d49235e0..c167958ae2a9 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > @@ -57,7 +57,9 @@ properties: > const: ipg > > clock-frequency: > - enum: [ 100000, 400000 ] > + minimum: 1 > + default: 100000 > + maximum: 400000 > > dmas: > items: > -- > 2.33.0 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |