From: Sudeep Holla <sudeep.holla@arm.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Wolfram Sang <wsa@kernel.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
Tian Tao <tiantao6@hisilicon.com>,
Zhiqi Song <songzhiqi1@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] i2c: xgene-slimpro: Fix wrong pointer passed to PTR_ERR()
Date: Mon, 1 Nov 2021 17:11:02 +0000 [thread overview]
Message-ID: <20211101171102.vht5arppz3gdz7vv@bogus> (raw)
In-Reply-To: <20211101140235.777322-1-weiyongjun1@huawei.com>
On Mon, Nov 01, 2021 at 02:02:35PM +0000, Wei Yongjun wrote:
> PTR_ERR should access the value just tested by IS_ERR, otherwise
> the wrong error code will be returned.
>
> Fixes: 7b6da7fe7bba ("mailbox: pcc: Use PCC mailbox channel pointer instead of standard")
> Reported-by: Hulk Robot <hulkci@huawei.com>
Thanks for spotting and fixing the issue.
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
next prev parent reply other threads:[~2021-11-01 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 14:02 [PATCH -next] i2c: xgene-slimpro: Fix wrong pointer passed to PTR_ERR() Wei Yongjun
2021-11-01 17:11 ` Sudeep Holla [this message]
2021-11-06 21:28 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101171102.vht5arppz3gdz7vv@bogus \
--to=sudeep.holla@arm.com \
--cc=f.fainelli@gmail.com \
--cc=hulkci@huawei.com \
--cc=jaswinder.singh@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=songzhiqi1@huawei.com \
--cc=tiantao6@hisilicon.com \
--cc=weiyongjun1@huawei.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox