From: minyard@acm.org
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Corey Minyard <minyard@acm.org>,
Andrew Manley <andrew.manley@sealingtech.com>
Subject: [PATCH v2 2/2] i2c:imx: Add an extra read at the end of an I2C slave read
Date: Fri, 12 Nov 2021 07:39:56 -0600 [thread overview]
Message-ID: <20211112133956.655179-3-minyard@acm.org> (raw)
In-Reply-To: <20211112133956.655179-1-minyard@acm.org>
From: Corey Minyard <minyard@acm.org>
The I2C slave interface expects that the driver will read ahead one
byte. The IMX driver/device doesn't do this, but simulate it so that
read operations get their index set correctly.
Signed-off-by: Corey Minyard <minyard@acm.org>
Tested-by: Andrew Manley <andrew.manley@sealingtech.com>
Reviewed-by: Andrew Manley <andrew.manley@sealingtech.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/i2c/busses/i2c-imx.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 27f969b3dc07..41355fc8bff4 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -771,6 +771,15 @@ static irqreturn_t i2c_imx_slave_handle(struct imx_i2c_struct *i2c_imx,
ctl &= ~I2CR_MTX;
imx_i2c_write_reg(ctl, i2c_imx, IMX_I2C_I2CR);
imx_i2c_read_reg(i2c_imx, IMX_I2C_I2DR);
+
+ /*
+ * The i2c slave interface requires one extra dummy
+ * read at the end to keep things in line. See the
+ * I2C slave docs for details.
+ */
+ i2c_imx_slave_event(i2c_imx,
+ I2C_SLAVE_READ_PROCESSED, &value);
+
i2c_imx_slave_finish_op(i2c_imx);
return IRQ_HANDLED;
}
--
2.25.1
next prev parent reply other threads:[~2021-11-12 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 13:39 [PATCH v2 0/2] i2c:imx: Deliver a timely stop on slave side, fix recv minyard
2021-11-12 13:39 ` [PATCH v2 1/2] i2c:imx: Add timer for handling the stop condition minyard
2021-11-12 13:39 ` minyard [this message]
2021-11-23 10:28 ` [PATCH v2 2/2] i2c:imx: Add an extra read at the end of an I2C slave read Wolfram Sang
2021-11-23 12:44 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112133956.655179-3-minyard@acm.org \
--to=minyard@acm.org \
--cc=andrew.manley@sealingtech.com \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).