From: Jean Delvare <jdelvare@suse.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: i801: Restore INTREN on unload
Date: Tue, 16 Nov 2021 11:23:07 +0100 [thread overview]
Message-ID: <20211116112307.039054d2@endymion> (raw)
In-Reply-To: <d4f76584-7548-baae-837d-b87300086196@linux.intel.com>
On Wed, 10 Nov 2021 16:31:41 +0200, Jarkko Nikula wrote:
> Now we restore INTREN on suspend but do not explicitly enable it after
> resume.
We also don't enable it when loading the driver, so this is consistent.
> I didn't fully get how RMI4 stack resumes but perhaps they will
> do some power on, reset, etc command transaction and that gets the
> INTREN enabled and allow host notify.
I didn't check either, but it shouldn't matter. If INTREN has to be set
for RMI4 to work, then it must have been set even before the i2c-i801
driver was loaded. In this case, my new code is a no-op (SMBHSTCNT will
be set to the value it already had, that is, INTREN is enabled at all
times).
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2021-11-16 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 15:02 [PATCH] i2c: i801: Restore INTREN on unload Jean Delvare
2021-11-10 14:31 ` Jarkko Nikula
2021-11-16 10:23 ` Jean Delvare [this message]
2021-11-23 9:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116112307.039054d2@endymion \
--to=jdelvare@suse.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).