From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64975C433F5 for ; Wed, 1 Dec 2021 11:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243226AbhLALDb (ORCPT ); Wed, 1 Dec 2021 06:03:31 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:59582 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229696AbhLALDa (ORCPT ); Wed, 1 Dec 2021 06:03:30 -0500 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1B18KtIV005616; Wed, 1 Dec 2021 12:00:00 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=3p8hf60x3MN36gSfgRlizyRmbFUL0MtXRK+OAqeqejE=; b=DCnp1tmRSfZ0IeJiok1WKICqN5ZzAiI2x3+BxIs9VKDvhfsRJCcn8SyJoPEnc2gPpmqn iDz66tvGJz3mX3mx5752PcXC0fQ9vjh75n3iv28sAqQT+O1d54gy4tBWMqPdc+zOKmN7 Ads/qZDKHedB5GdoFyKe5iO6KTClJRU1+J/17IyzrFQzyD16Vz7yhZCEgyYglhLJrmep 61DeKlTChmk3oVWMLIzm2HJA/6fQD95R7ln4plfei0lgDBn0LSeag6d3zlp9p3+4dR5e TDhYgJi63yq08A8Zg9JlW1/5d4yFZV3cggalA+5y8dWrzUb9YogtbMyZWFAxOGb2Y6jF Ug== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3cnx6ck24u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Dec 2021 12:00:00 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 29A8C10002A; Wed, 1 Dec 2021 12:00:00 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1CE16215150; Wed, 1 Dec 2021 12:00:00 +0100 (CET) Received: from gnbcxd0016.gnb.st.com (10.75.127.46) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Wed, 1 Dec 2021 11:59:59 +0100 Date: Wed, 1 Dec 2021 11:59:53 +0100 From: Alain Volmat To: Wolfram Sang , , , Subject: Re: [PATCH] i2c: stm32f7: remove noisy and imprecise log messages Message-ID: <20211201105953.GA825735@gnbcxd0016.gnb.st.com> Mail-Followup-To: Wolfram Sang , linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, pierre-yves.mordret@foss.st.com References: <20211130093816.12789-1-wsa@kernel.org> <20211130162534.GA813993@gnbcxd0016.gnb.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG1NODE3.st.com (10.75.127.3) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-30_10,2021-12-01_01,2020-04-07_01 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Tue, Nov 30, 2021 at 10:41:37PM +0100, Wolfram Sang wrote: > > > - looking at this area of code again, it appears that the function stm32f7_i2c_release_bus > > is ALWAYS returning 0. So it should actually be a void function. I thus > > propose, if you agree with that, that I propose, and apply a patch PRIOR to your/this patch > > to change that and remove the error checking of the stm32f7_i2c_release_bus function since it is useless. > > Is that fine for you ? > > Well, I'd think we can also apply this patch first and then make the > function void, but I don't really care about the order. But we should do > both, I agree. > Ok, I thus send a 2 patches serie with mine and yours reworked on top of mine together. Hope you don't mind.