From: Sui Chen <suichen@google.com>
To: linux-kernel@vger.kernel.org
Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
joel@jms.id.au, andrew@aj.id.au, tali.perry1@gmail.com,
benjaminfair@google.com, krellan@google.com, joe@perches.com,
Sui Chen <suichen@google.com>
Subject: [RFC Patch v2 0/3] I2C statistics as sysfs attributes
Date: Thu, 2 Dec 2021 18:37:25 -0800 [thread overview]
Message-ID: <20211203023728.3699610-1-suichen@google.com> (raw)
Add I2C statistics such as Bus Error counts and NACK counts as sysfs
attributes so they don't need to live in debugfs.
There are a few I2C statistics that are implemented in many I2C
controllers, such as bus error counts and NACK counts. Having those
statistics in sysfs will 1) allow for a unified definition across
various I2C drivers, and 2) make the statistics more ABI-stable and
available on devices with the debugfs disabled.
Overall the patch works as the following way:
1) An I2C statistics sysfs directory is created.
2) Each specific I2C driver is responsible for instantiating the
statistics available.
Test Process:
1. Clone the OpenBMC repository
2. `devtool modify`and apply patch to the linux-nuvoton recipe
3. Build image for quanta-gsj
4. Build QEMU
5. Run the image-bmc image in QEMU
Results:
root@gsj:/sys/class/i2c-adapter/i2c-1/stats# ls
ber_cnt i2c_speed nack_cnt rec_fail_cnt
rec_succ_cnt timeout_cnt tx_complete_cnt
root@gsj:/sys/class/i2c-adapter/i2c-1/stats# cat *
0
100000
0
0
0
0
53
Sui Chen (2):
i2c debug counters as sysfs attributes
add npcm7xx debug counters as sysfs attributes
Tali Perry (1):
i2c: npcm7xx: add tx_complete counter
drivers/i2c/busses/i2c-npcm7xx.c | 13 ++++
drivers/i2c/i2c-core-base.c | 2 +
drivers/i2c/i2c-dev.c | 103 +++++++++++++++++++++++++++++++
include/linux/i2c.h | 27 ++++++++
4 files changed, 145 insertions(+)
--
2.34.0.384.gca35af8252-goog
next reply other threads:[~2021-12-03 2:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 2:37 Sui Chen [this message]
2021-12-03 2:37 ` [RFC Patch v2 1/3] i2c debug counters as sysfs attributes Sui Chen
2021-12-03 2:50 ` Joe Perches
2021-12-03 5:35 ` Sui Chen
2021-12-03 5:54 ` Joe Perches
2021-12-03 2:37 ` [RFC Patch v2 2/3] i2c: npcm7xx: add tx_complete counter Sui Chen
2021-12-03 2:37 ` [RFC Patch v2 3/3] add npcm7xx debug counters as sysfs attributes Sui Chen
2021-12-03 16:37 ` [RFC Patch v2 0/3] I2C statistics " Wolfram Sang
2021-12-07 16:00 ` Sui Chen
2022-01-03 9:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203023728.3699610-1-suichen@google.com \
--to=suichen@google.com \
--cc=andrew@aj.id.au \
--cc=benjaminfair@google.com \
--cc=joe@perches.com \
--cc=joel@jms.id.au \
--cc=krellan@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).