From: Jan Dabros <jsd@semihalf.com>
To: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
jarkko.nikula@linux.intel.com
Cc: andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, wsa@kernel.org,
rrangel@chromium.org, mw@semihalf.com, jaz@semihalf.com,
jsd@semihalf.com, upstream@semihalf.com
Subject: [RFC 0/2] i2c-designware: Add support for AMD PSP semaphore
Date: Wed, 22 Dec 2021 10:45:56 +0100 [thread overview]
Message-ID: <20211222094558.2098791-1-jsd@semihalf.com> (raw)
This patchset comprises support for new i2c-designware controller setup on some
AMD Cezanne SoCs, where x86 is sharing i2c bus with PSP. PSP uses the same
controller and acts as an i2c arbitrator there (x86 is leasing bus from it).
First commit aims to improve generic i2c-designware code by adding extra locking
on probe() and disable() paths. I would like to ask someone with access to
boards which use Intel BayTrail(CONFIG_I2C_DESIGNWARE_BAYTRAIL) to verify
behavior of my changes on such setup.
Second commit adds support for new PSP semaphore arbitration mechanism.
Implementation is similar to the one from i2c-designware-baytrail.c however
there are two main differences:
1) Add new ACPI ID in order to protect against silent binding of the old driver
to the setup with PSP semaphore. Extra flag ARBITRATION_SEMAPHORE added to this
new _HID allows to recognize setup with PSP.
2) Beside acquire_lock() and release_lock() methods we are also applying quirks
to the lock_bus() and unlock_bus() global adapter methods. With this in place
all i2c clients drivers may lock i2c bus for a desired number of i2c
transactions (e.g. write-wait-read) without being aware of that such bus is
shared with another entity.
Mark this patchset as RFC, since waiting for new ACPI ID value. As a temporary
measure use "AMDI9999". Once proper one will be ready, will re-send this CL for
review & merge.
Looking forward to some feedback.
Jan Dabros (2):
i2c: designware: Add missing locks
i2c: designware: Add AMD PSP I2C bus support
MAINTAINERS | 1 +
drivers/acpi/acpi_apd.c | 1 +
drivers/i2c/busses/Kconfig | 20 ++
drivers/i2c/busses/Makefile | 1 +
drivers/i2c/busses/i2c-designware-amdpsp.c | 359 ++++++++++++++++++++
drivers/i2c/busses/i2c-designware-common.c | 12 +
drivers/i2c/busses/i2c-designware-core.h | 9 +-
drivers/i2c/busses/i2c-designware-master.c | 6 +
drivers/i2c/busses/i2c-designware-platdrv.c | 3 +
9 files changed, 411 insertions(+), 1 deletion(-)
create mode 100644 drivers/i2c/busses/i2c-designware-amdpsp.c
--
2.34.1.307.g9b7440fafd-goog
next reply other threads:[~2021-12-22 9:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 9:45 Jan Dabros [this message]
2021-12-22 9:45 ` [RFC 1/2] i2c: designware: Add missing locks Jan Dabros
2021-12-23 14:29 ` Jarkko Nikula
2021-12-23 15:50 ` Andy Shevchenko
2021-12-27 7:17 ` Jan Dąbroś
2021-12-22 9:45 ` [RFC 2/2] i2c: designware: Add AMD PSP I2C bus support Jan Dabros
2021-12-23 14:37 ` Jarkko Nikula
2021-12-27 11:34 ` Jan Dąbroś
2021-12-22 11:46 ` [RFC 0/2] i2c-designware: Add support for AMD PSP semaphore Andy Shevchenko
2021-12-22 17:56 ` Serge Semin
2021-12-22 18:21 ` Andy Shevchenko
2021-12-22 21:51 ` Jan Dąbroś
2021-12-25 15:58 ` Andy Shevchenko
2021-12-27 7:00 ` Jan Dąbroś
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222094558.2098791-1-jsd@semihalf.com \
--to=jsd@semihalf.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jaz@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mw@semihalf.com \
--cc=rrangel@chromium.org \
--cc=upstream@semihalf.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).