From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C570C433F5 for ; Mon, 14 Feb 2022 14:01:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354814AbiBNOB6 (ORCPT ); Mon, 14 Feb 2022 09:01:58 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354817AbiBNOB5 (ORCPT ); Mon, 14 Feb 2022 09:01:57 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41ABABCBF for ; Mon, 14 Feb 2022 06:01:48 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJbu2-0007Aw-Jd; Mon, 14 Feb 2022 15:00:30 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nJbu1-00GYgZ-R1; Mon, 14 Feb 2022 15:00:29 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nJbu0-0038OM-4h; Mon, 14 Feb 2022 15:00:28 +0100 Date: Mon, 14 Feb 2022 15:00:27 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Geert Uytterhoeven Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , kvm@vger.kernel.org, "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , alsa-devel@alsa-project.org, Andy Shevchenko , Liam Girdwood , Guenter Roeck , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal , linux-phy@lists.infradead.org, Oleksij Rempel , Lee Jones , "David S. Miller" , Peter Korsgaard , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Jakub Kicinski , Zhang Rui , platform-driver-x86@vger.kernel.org, linux-pwm@vger.kernel.org, Pengutronix Kernel Team , Corey Minyard , linux-pm@vger.kernel.org, John Garry , William Breathitt Gray , Mark Gross , linux-gpio@vger.kernel.org, Alex Williamson , Mark Brown , linux-mediatek@lists.infradead.org, Eric Auger , Takashi Iwai , Matthias Brugger , openipmi-developer@lists.sourceforge.net, Jaroslav Kysela , Benson Leung , linux-arm-kernel@lists.infradead.org, Sergey Shtylyov , Mun Yew Tham , Hans de Goede , Greg Kroah-Hartman , Yoshihiro Shimoda , Cornelia Huck , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , Zha Qipeng , Richard Weinberger , Niklas =?utf-8?Q?S=C3=B6derlund?= , Brian Norris , netdev@vger.kernel.org Subject: Re: [PATCH v2 1/2] platform: make platform_get_irq_optional() optional Message-ID: <20220214140027.npw6ddrxklarb6wp@pengutronix.de> References: <20220212201631.12648-1-s.shtylyov@omp.ru> <20220212201631.12648-2-s.shtylyov@omp.ru> <20220214071351.pcvstrzkwqyrg536@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mxy3a336cmbyaspi" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i2c@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --mxy3a336cmbyaspi Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Geert, On Mon, Feb 14, 2022 at 10:01:14AM +0100, Geert Uytterhoeven wrote: > Also IMHO, the dummy value handling is a red herring. Contrary to > optional clocks and resets, a missing optional interrupt does not > always mean there is nothing to do: in case of polling, something > else must definitely be done.=20 Note this is exactly why I don't like this change. I'd even go so far and claim that "a missing optional interrupt hardly ever means there is nothing to do". > So even if request_irq() would accept a dummy interrupt zero and just > do nothing, it would give the false impression that that is all there > is to do, while an actual check for zero with polling code handling > may still need to be present, thus leading to more not less bugs. Yes, a dummy irq value will just not be possible. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --mxy3a336cmbyaspi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmIKYHgACgkQwfwUeK3K 7AkfUwf+PjHT71nPQKjE5hOrUJs08gV3dPyFE+Lky6h3jHjtzp+VwX3waHB3n4Iy r1fdR+06wiK9BWaTD2PdT8FdEYo9n0yQlTx+03PQXtLFnutK7QSb0fBMQs7sVAfa nxp4CK8a1wlf0mzj1zSaeiGm6BYTsoJxoblrZ8hWbpbiVfhF6Eo5zXr0toHMI0WF QOhqgWNpQjHlpU+2paIvbOnBpNxJaXj3cycd6036NHAFQvZN5xrDdqHa+By0jeU0 bm8NmjRjwHCqvhBpRYUglt+KhyRYWWTC/83WFKviLwnPV7tnkh5ZhJE50aUUp1Lr hyNbZjQKG8NIOTLNKMgY4nM0uni8jg== =vr2/ -----END PGP SIGNATURE----- --mxy3a336cmbyaspi--