From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E837DC4332F for ; Mon, 21 Mar 2022 07:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344871AbiCUHZM (ORCPT ); Mon, 21 Mar 2022 03:25:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344856AbiCUHZE (ORCPT ); Mon, 21 Mar 2022 03:25:04 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D83DA19296 for ; Mon, 21 Mar 2022 00:23:37 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWCND-0006et-Tt; Mon, 21 Mar 2022 08:22:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nWCMp-0021t4-Og; Mon, 21 Mar 2022 08:22:16 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nWCMp-00AcZn-OA; Mon, 21 Mar 2022 08:22:15 +0100 Date: Mon, 21 Mar 2022 08:22:15 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jonathan Cameron Cc: Alexandre Belloni , Heiko Stuebner , Neil Armstrong , David Airlie , Alexandru Ardelean , Linus Walleij , Jonathan Cameron , Tomislav Denis , =?utf-8?B?QW5kcsOp?= Gustavo Nakagomi Lopez , Nuno =?utf-8?B?U8Oh?= , Paul Cercueil , Thierry Reding , linux-i2c@vger.kernel.org, Nobuhiro Iwamatsu , Oleksij Rempel , Lee Jones , linux-clk@vger.kernel.org, Jerome Brunet , linux-rtc@vger.kernel.org, Lars-Peter Clausen , Herbert Xu , Alexandre Torgue , Kevin Hilman , Bartosz Golaszewski , Russell King , linux-pwm@vger.kernel.org, Claudiu Beznea , linux-iio@vger.kernel.org, Andy Gross , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Keguang Zhang , Michael Turquette , Guenter Roeck , NXP Linux Team , Maxime Coquelin , Bjorn Andersson , Jean Delvare , Michal Simek , kernel@pengutronix.de, Michael Hennerich , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, Anand Ashok Dumbre , Vladimir Zapolskiy , linux-gpio@vger.kernel.org, Mark Brown , dri-devel@lists.freedesktop.org, Fabio Estevam , Matt Mackall , linux-amlogic@lists.infradead.org, Wim Van Sebroeck , Lars Povlsen , linux-hwmon@vger.kernel.org, Alessandro Zummo , linux-watchdog@vger.kernel.org, Stephen Boyd , Greg Kroah-Hartman , Patrice Chotard , linux-stm32@st-md-mailman.stormreply.com, Nicolas Ferre , UNGLinuxDriver@microchip.com, Vinod Koul , Cai Huoqing , linux-crypto@vger.kernel.org, Daniel Vetter , dmaengine@vger.kernel.org, Amireddy Mallikarjuna reddy , Shawn Guo , Steen Hegelund Subject: Re: [PATCH v8 02/16] clk: Provide new devm_clk helpers for prepared and enabled clocks Message-ID: <20220321072215.5lffm7qtpvg5ofk4@pengutronix.de> References: <20220314141643.22184-1-u.kleine-koenig@pengutronix.de> <20220314141643.22184-3-u.kleine-koenig@pengutronix.de> <20220319182936.06d75742@jic23-huawei> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oterd73bfcoy35ck" Content-Disposition: inline In-Reply-To: <20220319182936.06d75742@jic23-huawei> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i2c@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --oterd73bfcoy35ck Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 19, 2022 at 06:29:36PM +0000, Jonathan Cameron wrote: > On Mon, 14 Mar 2022 15:16:29 +0100 > Uwe Kleine-K=F6nig wrote: >=20 > > When a driver keeps a clock prepared (or enabled) during the whole > > lifetime of the driver, these helpers allow to simplify the drivers. > >=20 > > Reviewed-by: Jonathan Cameron > > Reviewed-by: Alexandru Ardelean > > Signed-off-by: Uwe Kleine-K=F6nig >=20 > One trivial thing below. >=20 > > --- > > drivers/clk/clk-devres.c | 31 ++++++++++++++ > > include/linux/clk.h | 90 +++++++++++++++++++++++++++++++++++++++- > > 2 files changed, 120 insertions(+), 1 deletion(-) > >=20 > > diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c > > index fb7761888b30..4707fe718f0b 100644 > > --- a/drivers/clk/clk-devres.c > > +++ b/drivers/clk/clk-devres.c > > @@ -67,12 +67,43 @@ struct clk *devm_clk_get(struct device *dev, const = char *id) > > } > > EXPORT_SYMBOL(devm_clk_get); > > =20 > > +struct clk *devm_clk_get_prepared(struct device *dev, const char *id) > > +{ > > + return __devm_clk_get(dev, id, clk_get, clk_prepare, clk_unprepare); >=20 > Nitpick but this spacing before } in functions is rather unusual and not > in keeping with the existing code in this file. >=20 > > + > > +} ack, I fixed that in my tree, so this will be part of an v9. I won't send it just for this change, though. I fixed three further functions that had a similar empty line, too. Thanks for looking Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --oterd73bfcoy35ck Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmI4J6MACgkQwfwUeK3K 7Ak5sAf/aG3oVD1FgzqJLWD3uSmF0uX0/3lky1l56go3LpRjDym8tlGglXT4z7Hl Z3q8YXru6LSihHT/n6V4EUdpV6f49dxPfrr9hu9OFU+UY0Cd7NgisKr+0Wi61dbS d8IVGHwcCPqBZanHdAEjhle7d7WdWhfukR1oLljd8B2XM6qP2jQgjFWzrSJfZ+hd qd6k9TcfIHjy8n8xBtyIYSvYZbywqfa+wJeU54fe4fp4NNPVTmxGtzHFNDipSZGL uF+yg7qDqSezst7wO3dNeblEvpVZfG9TZAXvGMCZQLn9x4b35iSmZtLVPN+HZZM4 WBr/EA6mCSOr4iHXCKfNr4UegGV4/w== =gON5 -----END PGP SIGNATURE----- --oterd73bfcoy35ck--