Re: [PATCH v4 8/9] i2c: npcm: Remove own slave addresses 2:10

Tyrone Ting
2022-05-11T01:40:04Z

Hi Andy:

Thank you for your comments and they will be addressed.

Andy Shevchenko <andriy.shevchenko@linux.intel.com> 於 2022年5月10日 週二 下午6:19寫道：
>
> On Tue, May 10, 2022 at 05:16:53PM +0800, Tyrone Ting wrote:
> > From: Tali Perry <tali.perry1@gmail.com>
> >
> > NPCM can support up to 10 own slave addresses.
> > In practice, only one address is actually being used.
> > In order to access addresses 2 and above, need to switch
> > register banks. The switch needs spinlock.
> > To avoid using spinlock for this useless feature
> > removed support of SA >= 2.
>
> > Also fix returned slave event enum.
> >
> > Remove some comment since the bank selection is not
> > required. The bank selection is not required since
> > the supported slave addresses are reduced.
>
> Fancy indentation. Please fix it in all your commit messages where it applies.
>
> ...
>
> > + if (addr_type > I2C_SLAVE_ADDR2 && addr_type <= I2C_SLAVE_ADDR10) {
> > + dev_err(bus->dev,
> > + "try to enable more then 2 SA not supported\n");
>
> Make it one line and drop {}.
>
> > + }
>
> ...
>
> > + if (addr_type > I2C_SLAVE_ADDR2 && addr_type <= I2C_SLAVE_ADDR10) {
> > + dev_err(bus->dev,
> > + "get slave: try to use more then 2 slave addresses not supported\n");
>
> As per above be consistent with abbreviations ("SA" here, which makes line
> shorter) and follow the above recommendation.
>
> > + }
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Best Regards,
Tyrone