From: Potin Lai <potin.lai.pt@gmail.com>
To: Brendan Higgins <brendanhiggins@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Cc: Patrick Williams <patrick@stwcx.xyz>,
Porin Lai <potin.lai@quantatw.com>,
Porin Lai <potin.lai.pt@gmail.com>,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] aspeed: i2c: add manual clock setup feature
Date: Mon, 30 May 2022 19:40:56 +0800 [thread overview]
Message-ID: <20220530114056.8722-1-potin.lai.pt@gmail.com> (raw)
From: Porin Lai <potin.lai.pt@gmail.com>
Add properties for manual tuning i2c clock timing register.
* aspeed,i2c-manual-clk: Enable aspeed i2c clock manual setup
* aspeed,i2c-base-clk-div: Base Clock divisor (tBaseClk)
* aspeed,i2c-clk-high-cycle: Cycles of clock-high pulse (tClkHigh)
* aspeed,i2c-clk-low-cycle: Cycles of clock-low pulse (tClkLow)
Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
---
drivers/i2c/busses/i2c-aspeed.c | 55 ++++++++++++++++++++++++++++++++-
1 file changed, 54 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 67e8b97c0c95..1f4b5c4b5bf4 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -898,6 +898,56 @@ static int aspeed_i2c_init_clk(struct aspeed_i2c_bus *bus)
return 0;
}
+/* precondition: bus.lock has been acquired. */
+static int aspeed_i2c_manual_clk_setup(struct aspeed_i2c_bus *bus)
+{
+ u32 divisor, clk_high, clk_low, clk_reg_val;
+
+ if (device_property_read_u32(bus->dev, "aspeed,i2c-base-clk-div",
+ &divisor) != 0) {
+ dev_err(bus->dev, "Could not read aspeed,i2c-base-clk-div\n");
+ return -EINVAL;
+ } else if (divisor > ASPEED_I2CD_TIME_BASE_DIVISOR_MASK) {
+ dev_err(bus->dev, "Invalid aspeed,i2c-base-clk-div: %u\n",
+ divisor);
+ return -EINVAL;
+ }
+
+ if (device_property_read_u32(bus->dev, "aspeed,i2c-clk-high-cycle",
+ &clk_high) != 0) {
+ dev_err(bus->dev, "Could not read aspeed,i2c-clk-high-cycle\n");
+ return -EINVAL;
+ } else if (clk_high > ASPEED_I2CD_TIME_SCL_REG_MAX) {
+ dev_err(bus->dev, "Invalid aspeed,i2c-clk-high-cycle: %u\n",
+ clk_high);
+ return -EINVAL;
+ }
+
+ if (device_property_read_u32(bus->dev, "aspeed,i2c-clk-low-cycle",
+ &clk_low) != 0) {
+ dev_err(bus->dev, "Could not read aspeed,i2c-clk-low-cycle\n");
+ return -EINVAL;
+ } else if (clk_low > ASPEED_I2CD_TIME_SCL_REG_MAX) {
+ dev_err(bus->dev, "Invalid aspeed,i2c-clk-low-cycle: %u\n",
+ clk_low);
+ return -EINVAL;
+ }
+
+ clk_reg_val = readl(bus->base + ASPEED_I2C_AC_TIMING_REG1);
+ clk_reg_val &= (ASPEED_I2CD_TIME_TBUF_MASK |
+ ASPEED_I2CD_TIME_THDSTA_MASK |
+ ASPEED_I2CD_TIME_TACST_MASK);
+ clk_reg_val |= (divisor & ASPEED_I2CD_TIME_BASE_DIVISOR_MASK)
+ | ((clk_high << ASPEED_I2CD_TIME_SCL_HIGH_SHIFT)
+ & ASPEED_I2CD_TIME_SCL_HIGH_MASK)
+ | ((clk_low << ASPEED_I2CD_TIME_SCL_LOW_SHIFT)
+ & ASPEED_I2CD_TIME_SCL_LOW_MASK);
+ writel(clk_reg_val, bus->base + ASPEED_I2C_AC_TIMING_REG1);
+ writel(ASPEED_NO_TIMEOUT_CTRL, bus->base + ASPEED_I2C_AC_TIMING_REG2);
+
+ return 0;
+}
+
/* precondition: bus.lock has been acquired. */
static int aspeed_i2c_init(struct aspeed_i2c_bus *bus,
struct platform_device *pdev)
@@ -908,7 +958,10 @@ static int aspeed_i2c_init(struct aspeed_i2c_bus *bus,
/* Disable everything. */
writel(0, bus->base + ASPEED_I2C_FUN_CTRL_REG);
- ret = aspeed_i2c_init_clk(bus);
+ if (of_property_read_bool(pdev->dev.of_node, "aspeed,i2c-manual-clk"))
+ ret = aspeed_i2c_manual_clk_setup(bus);
+ else
+ ret = aspeed_i2c_init_clk(bus);
if (ret < 0)
return ret;
--
2.17.1
next reply other threads:[~2022-05-30 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 11:40 Potin Lai [this message]
2022-05-31 13:47 ` [PATCH 1/1] aspeed: i2c: add manual clock setup feature Patrick Williams
2022-05-31 14:21 ` Potin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220530114056.8722-1-potin.lai.pt@gmail.com \
--to=potin.lai.pt@gmail.com \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=patrick@stwcx.xyz \
--cc=potin.lai@quantatw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox