Linux I2C development
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Terry Bowman <Terry.Bowman@amd.com>
Cc: Yi Zhang <yi.zhang@redhat.com>,
	linux-i2c@vger.kernel.org,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [bug report] kmemleak from driver i2c_piix4
Date: Wed, 22 Jun 2022 08:39:21 +0200	[thread overview]
Message-ID: <20220622083921.69c9f359@endymion.delvare> (raw)
In-Reply-To: <0ce578ba-cdc7-6084-6119-10170d5e80a1@amd.com>

Hi Terry,

On Tue, 21 Jun 2022 09:29:44 -0500, Terry Bowman wrote:
> On 6/21/22 07:48, Jean Delvare wrote:
> 
> > Yi Zhang, can you please test this patch and confirm that it solves the
> > memory leak?
> > 
> > Terry, please review/comment.
> > 
> > If my analysis is correct then the sp5100_wdt and thinkpad_acpi drivers
> > suffer from a similar leak and need to be fixed the same way.
> 
> Your analysis is correct. The kfree() call is missing during the release in i2c-piix4 and 
> sp5100_tco driver patches. Let me know if there is anything I can do.

I've submitted patches for the 3 drivers. They are pretty
straightforward, but anything you'd be able to review or test would be
welcome.

Thanks,
-- 
Jean Delvare
SUSE L3 Support

  parent reply	other threads:[~2022-06-22  6:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-11  9:08 [bug report] kmemleak from driver i2c_piix4 Yi Zhang
2022-06-17  7:38 ` Jean Delvare
2022-06-17 13:33   ` Yi Zhang
2022-06-21 12:48     ` Jean Delvare
2022-06-21 14:29       ` Terry Bowman
2022-06-22  5:16         ` Yi Zhang
2022-06-22  6:39         ` Jean Delvare [this message]
2022-06-22 13:41           ` Terry Bowman
2022-06-22 15:36           ` Terry Bowman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220622083921.69c9f359@endymion.delvare \
    --to=jdelvare@suse.de \
    --cc=Terry.Bowman@amd.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox