Re: [PATCH v1] i2c: imx: Retry transfer on transient failure

Marco Felsch
2022-07-12T12:02:18Z

On 22-07-12, Wolfram Sang wrote:
>
> > > +#define I2C_IMX_MAX_RETRIES 3 /* Retries on arbitration loss */
> >
> > Just one question: Why 3 and should we document this within the commit
> > message?
>
> Note that you can always change this from userspace via i2c-dev and the
> I2C_RETRIES ioctl. So, it is really about a default value here.

Ah okay, this makes now a bit more sense. So the message should point
out to set it to a more reasonable default value and that 3 looks like
common sense for most of the drivers if I got this correctly. If this is
correct, would it make more sense to set it within the core?

Regards,
Marco