From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Vinod Koul <vkoul@kernel.org>, Wolfram Sang <wsa@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] i2c: qcom-geni: Make it possible to run i2cdetect
Date: Sat, 16 Jul 2022 20:50:24 -0700 [thread overview]
Message-ID: <20220717035027.2135106-1-bjorn.andersson@linaro.org> (raw)
Attempting to run i2cdetect shows that error handling in the GENI I2C driver
could be better.
The first issue is that errors aren't returned from the driver. Following this
is an issue that if a timeout occurs the current operation is aborted, but the
abort code races with the isr so the abort times out as well. Lastly when this
happens, the driver is quite noisy, making it impossible to run i2cdetect on
the serial console.
With this series in place, I was able to run i2cdetect on the db845c and two
sc8180x devices - and get useful output.
Bjorn Andersson (3):
i2c: qcom-geni: Use the correct return value
i2c: qcom-geni: Propagate GENI_ABORT_DONE to geni_i2c_abort_xfer()
i2c: qcom-geni: Silence NACK and GENI_TIMEOUT
drivers/i2c/busses/i2c-qcom-geni.c | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
--
2.35.1
next reply other threads:[~2022-07-17 3:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 3:50 Bjorn Andersson [this message]
2022-07-17 3:50 ` [PATCH 1/3] i2c: qcom-geni: Use the correct return value Bjorn Andersson
2022-07-18 5:36 ` Vinod Koul
2022-07-18 22:28 ` Bjorn Andersson
2022-07-19 20:36 ` Andrew Halaney
2022-07-20 4:31 ` Vinod Koul
2022-07-24 5:04 ` Wolfram Sang
2022-07-24 7:30 ` Johan Hovold
2022-07-24 18:37 ` Wolfram Sang
2022-07-24 18:39 ` Wolfram Sang
2022-07-17 3:50 ` [PATCH 2/3] i2c: qcom-geni: Propagate GENI_ABORT_DONE to geni_i2c_abort_xfer() Bjorn Andersson
2022-07-18 5:36 ` Vinod Koul
2022-07-19 20:50 ` Andrew Halaney
2022-07-19 20:57 ` Andrew Halaney
2022-07-24 5:15 ` Wolfram Sang
2022-07-24 5:15 ` Wolfram Sang
2022-07-17 3:50 ` [PATCH 3/3] i2c: qcom-geni: Silence NACK and GENI_TIMEOUT Bjorn Andersson
2022-07-18 5:37 ` Vinod Koul
2022-07-24 5:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220717035027.2135106-1-bjorn.andersson@linaro.org \
--to=bjorn.andersson@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).