linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 01/13] i2c: rk3x: Add rv1126 support
       [not found] <20220907160207.3845791-1-jagan@edgeble.ai>
@ 2022-09-07 16:01 ` Jagan Teki
  2022-09-09 17:28   ` Heiko Stuebner
  0 siblings, 1 reply; 3+ messages in thread
From: Jagan Teki @ 2022-09-07 16:01 UTC (permalink / raw)
  To: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Kever Yang
  Cc: linux-arm-kernel, linux-rockchip, devicetree, Jagan Teki,
	linux-i2c, David Wu

Add i2c support for Rockchip RV1126 SoC.

Cc: linux-i2c@vger.kernel.org
Signed-off-by: David Wu <david.wu@rock-chips.com>
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Changes for v4:
- new patch

 drivers/i2c/busses/i2c-rk3x.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 2e98e7793bba..d1658ed76562 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -1165,6 +1165,11 @@ static const struct rk3x_i2c_soc_data rv1108_soc_data = {
 	.calc_timings = rk3x_i2c_v1_calc_timings,
 };
 
+static const struct rk3x_i2c_soc_data rv1126_soc_data = {
+	.grf_offset = 0x118,
+	.calc_timings = rk3x_i2c_v1_calc_timings,
+};
+
 static const struct rk3x_i2c_soc_data rk3066_soc_data = {
 	.grf_offset = 0x154,
 	.calc_timings = rk3x_i2c_v0_calc_timings,
@@ -1195,6 +1200,10 @@ static const struct of_device_id rk3x_i2c_match[] = {
 		.compatible = "rockchip,rv1108-i2c",
 		.data = &rv1108_soc_data
 	},
+	{
+		.compatible = "rockchip,rv1126-i2c",
+		.data = &rv1126_soc_data
+	},
 	{
 		.compatible = "rockchip,rk3066-i2c",
 		.data = &rk3066_soc_data
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v4 01/13] i2c: rk3x: Add rv1126 support
  2022-09-07 16:01 ` [PATCH v4 01/13] i2c: rk3x: Add rv1126 support Jagan Teki
@ 2022-09-09 17:28   ` Heiko Stuebner
  2022-09-12 19:22     ` Jagan Teki
  0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2022-09-09 17:28 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Kever Yang, Jagan Teki
  Cc: linux-arm-kernel, linux-rockchip, devicetree, Jagan Teki,
	linux-i2c, David Wu

Hi Jagan,

it looks like this is missing Wolfram Sang, the i2c maintainer?

Am Mittwoch, 7. September 2022, 18:01:55 CEST schrieb Jagan Teki:
> Add i2c support for Rockchip RV1126 SoC.
> 
> Cc: linux-i2c@vger.kernel.org
> Signed-off-by: David Wu <david.wu@rock-chips.com>
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


Heiko

> ---
> Changes for v4:
> - new patch
> 
>  drivers/i2c/busses/i2c-rk3x.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 2e98e7793bba..d1658ed76562 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -1165,6 +1165,11 @@ static const struct rk3x_i2c_soc_data rv1108_soc_data = {
>  	.calc_timings = rk3x_i2c_v1_calc_timings,
>  };
>  
> +static const struct rk3x_i2c_soc_data rv1126_soc_data = {
> +	.grf_offset = 0x118,
> +	.calc_timings = rk3x_i2c_v1_calc_timings,
> +};
> +
>  static const struct rk3x_i2c_soc_data rk3066_soc_data = {
>  	.grf_offset = 0x154,
>  	.calc_timings = rk3x_i2c_v0_calc_timings,
> @@ -1195,6 +1200,10 @@ static const struct of_device_id rk3x_i2c_match[] = {
>  		.compatible = "rockchip,rv1108-i2c",
>  		.data = &rv1108_soc_data
>  	},
> +	{
> +		.compatible = "rockchip,rv1126-i2c",
> +		.data = &rv1126_soc_data
> +	},
>  	{
>  		.compatible = "rockchip,rk3066-i2c",
>  		.data = &rk3066_soc_data
> 





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4 01/13] i2c: rk3x: Add rv1126 support
  2022-09-09 17:28   ` Heiko Stuebner
@ 2022-09-12 19:22     ` Jagan Teki
  0 siblings, 0 replies; 3+ messages in thread
From: Jagan Teki @ 2022-09-12 19:22 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Rob Herring, Krzysztof Kozlowski, Kever Yang, linux-arm-kernel,
	linux-rockchip, devicetree, linux-i2c, David Wu

Hi Heiko,

On Fri, 9 Sept 2022 at 22:58, Heiko Stuebner <heiko@sntech.de> wrote:
>
> Hi Jagan,
>
> it looks like this is missing Wolfram Sang, the i2c maintainer?

My bad. I will add him in the next version. Thanks.

Jagan.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-12 19:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20220907160207.3845791-1-jagan@edgeble.ai>
2022-09-07 16:01 ` [PATCH v4 01/13] i2c: rk3x: Add rv1126 support Jagan Teki
2022-09-09 17:28   ` Heiko Stuebner
2022-09-12 19:22     ` Jagan Teki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).