From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 841E5ECAAD3 for ; Wed, 14 Sep 2022 11:22:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbiINLWy (ORCPT ); Wed, 14 Sep 2022 07:22:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbiINLWx (ORCPT ); Wed, 14 Sep 2022 07:22:53 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 892B15A3EA for ; Wed, 14 Sep 2022 04:22:52 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYQTb-0006iM-Vr; Wed, 14 Sep 2022 13:22:43 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oYQTZ-00035r-AR; Wed, 14 Sep 2022 13:22:41 +0200 Date: Wed, 14 Sep 2022 13:22:41 +0200 From: Oleksij Rempel To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Oleksij Rempel , Shawn Guo , Wolfram Sang , Dan Carpenter , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , linux-i2c@vger.kernel.org Subject: Re: [PATCH] i2c: imx: If pm_runtime_get_sync() returned 1 device access is possible Message-ID: <20220914112241.GC31791@pengutronix.de> References: <20220912132040.156713-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220912132040.156713-1-u.kleine-koenig@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i2c@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, Sep 12, 2022 at 03:20:40PM +0200, Uwe Kleine-König wrote: > pm_runtime_get_sync() returning 1 also means the device is powered. So > resetting the chip registers in .remove() is possible and should be > done. > > Reported-by: Dan Carpenter > Fixes: d98bdd3a5b50 ("i2c: imx: Make sure to unregister adapter on remove()") > Signed-off-by: Uwe Kleine-König Acked-by: Oleksij Rempel Thank you! > --- > drivers/i2c/busses/i2c-imx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index e47fa3465671..3082183bd66a 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -1583,7 +1583,7 @@ static int i2c_imx_remove(struct platform_device *pdev) > if (i2c_imx->dma) > i2c_imx_dma_free(i2c_imx); > > - if (ret == 0) { > + if (ret >= 0) { > /* setup chip registers to defaults */ > imx_i2c_write_reg(0, i2c_imx, IMX_I2C_IADR); > imx_i2c_write_reg(0, i2c_imx, IMX_I2C_IFDR); > -- > 2.37.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |