From: Patrick Rudolph <patrick.rudolph@9elements.com>
To: Peter Rosin <peda@axentia.se>
Cc: robh@kernel.org, laurent.pinchart@ideasonboard.com,
wsa@kernel.org, Patrick Rudolph <patrick.rudolph@9elements.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v9 4/4] i2c: muxes: pca954x: Add regulator support
Date: Fri, 7 Oct 2022 09:53:53 +0200 [thread overview]
Message-ID: <20221007075354.568752-5-patrick.rudolph@9elements.com> (raw)
In-Reply-To: <20221007075354.568752-1-patrick.rudolph@9elements.com>
Add a vdd regulator and enable it for boards that have the
mux powered off by default.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/muxes/i2c-mux-pca954x.c | 34 ++++++++++++++++++++++++-----
1 file changed, 29 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
index 992976fa6798..857a4ec387be 100644
--- a/drivers/i2c/muxes/i2c-mux-pca954x.c
+++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
@@ -49,6 +49,7 @@
#include <linux/module.h>
#include <linux/pm.h>
#include <linux/property.h>
+#include <linux/regulator/consumer.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <dt-bindings/mux/mux.h>
@@ -133,6 +134,7 @@ struct pca954x {
struct irq_domain *irq;
unsigned int irq_mask;
raw_spinlock_t lock;
+ struct regulator *supply;
};
/* Provide specs for the MAX735x, PCA954x and PCA984x types we know about */
@@ -473,6 +475,9 @@ static void pca954x_cleanup(struct i2c_mux_core *muxc)
struct pca954x *data = i2c_mux_priv(muxc);
int c, irq;
+ if (!IS_ERR_OR_NULL(data->supply))
+ regulator_disable(data->supply);
+
if (data->irq) {
for (c = 0; c < data->chip->nchans; c++) {
irq = irq_find_mapping(data->irq, c);
@@ -531,15 +536,32 @@ static int pca954x_probe(struct i2c_client *client,
pca954x_select_chan, pca954x_deselect_mux);
if (!muxc)
return -ENOMEM;
+
data = i2c_mux_priv(muxc);
i2c_set_clientdata(client, muxc);
data->client = client;
+ data->supply = devm_regulator_get(dev, "vdd");
+ if (IS_ERR(data->supply)) {
+ ret = PTR_ERR(data->supply);
+ if (ret != -EPROBE_DEFER)
+ dev_err(dev, "Failed to request regulator: %d\n", ret);
+ return ret;
+ }
+
+ ret = regulator_enable(data->supply);
+ if (ret) {
+ dev_err(dev, "Failed to enable regulator: %d\n", ret);
+ return ret;
+ }
+
/* Reset the mux if a reset GPIO is specified. */
gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
- if (IS_ERR(gpio))
- return PTR_ERR(gpio);
+ if (IS_ERR(gpio)) {
+ ret = PTR_ERR(gpio);
+ goto fail_cleanup;
+ }
if (gpio) {
udelay(1);
gpiod_set_value_cansleep(gpio, 0);
@@ -556,7 +578,7 @@ static int pca954x_probe(struct i2c_client *client,
ret = i2c_get_device_id(client, &id);
if (ret && ret != -EOPNOTSUPP)
- return ret;
+ goto fail_cleanup;
if (!ret &&
(id.manufacturer_id != data->chip->id.manufacturer_id ||
@@ -564,7 +586,8 @@ static int pca954x_probe(struct i2c_client *client,
dev_warn(dev, "unexpected device id %03x-%03x-%x\n",
id.manufacturer_id, id.part_id,
id.die_revision);
- return -ENODEV;
+ ret = -ENODEV;
+ goto fail_cleanup;
}
}
@@ -583,7 +606,8 @@ static int pca954x_probe(struct i2c_client *client,
ret = pca954x_init(client, data);
if (ret < 0) {
dev_warn(dev, "probe failed\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto fail_cleanup;
}
ret = pca954x_irq_setup(muxc);
--
2.37.3
next prev parent reply other threads:[~2022-10-07 7:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 7:53 [v9 0/4] Add support for Maxim MAX735x/MAX736x variants Patrick Rudolph
2022-10-07 7:53 ` [v9 1/4] dt-bindings: i2c: Add " Patrick Rudolph
2022-10-08 11:50 ` Serge Semin
2022-10-09 15:25 ` Krzysztof Kozlowski
2022-10-09 18:03 ` Serge Semin
2022-10-10 10:26 ` Krzysztof Kozlowski
2022-10-07 7:53 ` [v9 2/4] i2c: muxes: pca954x: Add MAX735x/MAX736x support Patrick Rudolph
2022-10-07 7:53 ` [v9 3/4] i2c: muxes: pca954x: Configure MAX7357 in enhanced mode Patrick Rudolph
2022-10-08 12:54 ` Serge Semin
2022-10-09 16:36 ` Peter Rosin
2022-10-09 18:13 ` Serge Semin
2022-10-07 7:53 ` Patrick Rudolph [this message]
2022-10-08 16:07 ` [v9 4/4] i2c: muxes: pca954x: Add regulator support Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221007075354.568752-5-patrick.rudolph@9elements.com \
--to=patrick.rudolph@9elements.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox