From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D44FC4332F for ; Thu, 20 Oct 2022 10:35:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbiJTKf4 (ORCPT ); Thu, 20 Oct 2022 06:35:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230158AbiJTKfz (ORCPT ); Thu, 20 Oct 2022 06:35:55 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 938FE11F48B; Thu, 20 Oct 2022 03:35:53 -0700 (PDT) Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4MtP9b6J9Sz6HJVl; Thu, 20 Oct 2022 18:34:43 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 20 Oct 2022 12:35:42 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 20 Oct 2022 11:35:42 +0100 Date: Thu, 20 Oct 2022 11:35:41 +0100 From: Jonathan Cameron To: Wolfram Sang CC: Jason Gerecke , Andy Shevchenko , linux-i2c , linux-iio , Jonathan Cameron , "Lars-Peter Clausen" , LKML , Ping Cheng , "Tobita, Tatsunosuke" , Jason Gerecke , Ping Cheng Subject: Re: [PATCH v2] i2c: Use u8 type in i2c transfer calls Message-ID: <20221020113541.0000490e@huawei.com> In-Reply-To: References: <20220718153448.173652-1-jason.gerecke@wacom.com> <20220803145937.698603-1-jason.gerecke@wacom.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Wed, 19 Oct 2022 23:37:51 +0200 Wolfram Sang wrote: > > I spent a little time trying to put together a Coccinelle script to > > take care of everything but I eventually realized the size of the task > > was larger than I was comfortable with. In particular, even though I > > might be able to put together a script, I worry I don't have a good > > way to test the resulting treewide changes to avoid regression. > > The coccinelle scripts are one thing. I am quite familiar with it, so I > regard this as "work but doable". My main headache is that I am not sure > about the best way to upstream the result. I'd like to avoid a flag-day > where all drivers across all subsystems need to be converted, but I > don't really see a way around it. Preparing such a branch and make sure > it does not regress is quite some work on a moving target. Horrendous though it is, you 'could' take it via a void * intermediate step. That way all the warnings will disappear (I think). You then move all the callers to providing u8 * then switch the function to that. Could happen over several cycles with coccicheck moaning about any new entries in the meantime. Jonathan > >