From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Michael Wu <michael.wu@vatics.com>,
Tian Ye <tianye@sugon.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: [PATCH v3 12/12] i2c: designware: Add comment to custom register value constants
Date: Mon, 7 Nov 2022 15:42:48 +0200 [thread overview]
Message-ID: <20221107134248.864890-13-jarkko.nikula@linux.intel.com> (raw)
In-Reply-To: <20221107134248.864890-1-jarkko.nikula@linux.intel.com>
DW_IC_COMP_VERSION register contains the ASCII representation of the
Synopsys component version. Here 0x3131312A == "111*" means version
1.11* required for DW_IC_SDA_HOLD register availability where '*' means
any letter starting from 'a'.
DW_IC_COMP_TYPE is constant and is derived from two ASCII letters "DW"
followed by a 16-bit unsigned number.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3: Updated commit log and comment about DW_IC_COMP_VERSION and
DW_IC_SDA_HOLD_MIN_VERS define.
---
drivers/i2c/busses/i2c-designware-core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h
index 0668888d557d..95ebc5eaa5d1 100644
--- a/drivers/i2c/busses/i2c-designware-core.h
+++ b/drivers/i2c/busses/i2c-designware-core.h
@@ -79,9 +79,9 @@
#define DW_IC_CLR_RESTART_DET 0xa8
#define DW_IC_COMP_PARAM_1 0xf4
#define DW_IC_COMP_VERSION 0xf8
-#define DW_IC_SDA_HOLD_MIN_VERS 0x3131312A
+#define DW_IC_SDA_HOLD_MIN_VERS 0x3131312A /* "111*" == v1.11* */
#define DW_IC_COMP_TYPE 0xfc
-#define DW_IC_COMP_TYPE_VALUE 0x44570140
+#define DW_IC_COMP_TYPE_VALUE 0x44570140 /* "DW" + 0x0140 */
#define DW_IC_INTR_RX_UNDER BIT(0)
#define DW_IC_INTR_RX_OVER BIT(1)
--
2.35.1
next prev parent reply other threads:[~2022-11-07 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 13:42 [PATCH v3 00/12] i2c: designware: Slave fixes and generic cleanups Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 01/12] i2c: designware: Fix slave state machine for sequential reads Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 02/12] i2c: designware: Empty receive FIFO in slave interrupt handler Jarkko Nikula
2022-11-12 6:57 ` Wolfram Sang
2022-11-14 9:53 ` Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 03/12] i2c: designware: Define software status flags with BIT() Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 04/12] i2c: designware: Remove needless initializations from i2c_dw_reg_slave() Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 05/12] i2c: designware: Remove unused completion code from i2c-designware-slave Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 06/12] i2c: designware: Simplify slave interrupt handler nesting Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 07/12] i2c: designware: Do not process interrupt when device is suspended Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 08/12] i2c: designware: Move debug print in i2c_dw_isr() Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 09/12] i2c: designware: Simplify master interrupt handler nesting Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 10/12] i2c: designware: Remove common i2c_dw_disable_int() Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 11/12] i2c: designware: Align defines in i2c-designware-core.h Jarkko Nikula
2022-11-07 13:42 ` Jarkko Nikula [this message]
2022-11-12 6:57 ` [PATCH v3 00/12] i2c: designware: Slave fixes and generic cleanups Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107134248.864890-13-jarkko.nikula@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=michael.wu@vatics.com \
--cc=mika.westerberg@linux.intel.com \
--cc=tianye@sugon.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox