public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Corentin Labbe <clabbe@baylibre.com>
To: wsa@kernel.org
Cc: jdelvare@suse.de, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Corentin Labbe <clabbe@baylibre.com>
Subject: [PATCH] i2c: smbus: support new RAM variant for SPD
Date: Mon,  7 Nov 2022 16:06:02 +0000	[thread overview]
Message-ID: <20221107160602.1912225-1-clabbe@baylibre.com> (raw)

On my x05 laptop I got:
Memory type 0x12 not supported yet, not instantiating SPD

Adding the 0x12 case lead to a successful instantiated SPD AT24 EEPROM.
i801_smbus 0000:00:1f.3: SMBus using polling
i2c i2c-6: 2/2 memory slots populated (from DMI)
at24 6-0050: 256 byte spd EEPROM, read-only
i2c i2c-6: Successfully instantiated SPD at 0x50
at24 6-0051: 256 byte spd EEPROM, read-only
i2c i2c-6: Successfully instantiated SPD at 0x51

And then, I decoded it successfully via decode-dimms.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
The result of decode-dimms could be found at http://kernel.montjoie.ovh/zoo/x05/decode-dimms.txt
Since RAM is DDR, I wanted to add '/* DDR */' comment, but I didnt find any document with
proof that this 0x12 is for DDR.

 drivers/i2c/i2c-smbus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
index 07c92c8495a3..6dca19c994db 100644
--- a/drivers/i2c/i2c-smbus.c
+++ b/drivers/i2c/i2c-smbus.c
@@ -362,6 +362,7 @@ void i2c_register_spd(struct i2c_adapter *adap)
 	}
 
 	switch (common_mem_type) {
+	case 0x12:
 	case 0x13:	/* DDR2 */
 	case 0x18:	/* DDR3 */
 	case 0x1C:	/* LPDDR2 */
-- 
2.37.4


             reply	other threads:[~2022-11-07 16:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07 16:06 Corentin Labbe [this message]
2022-11-08 10:48 ` [PATCH] i2c: smbus: support new RAM variant for SPD Jean Delvare
2022-11-14  9:17   ` Corentin LABBE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221107160602.1912225-1-clabbe@baylibre.com \
    --to=clabbe@baylibre.com \
    --cc=jdelvare@suse.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox