From: Primoz Fiser <primoz.fiser@norik.com>
To: Oleksij Rempel <linux@rempel-privat.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: upstream@lists.phytec.de
Subject: [PATCH] i2c: imx: increase retries on arbitration loss
Date: Fri, 16 Dec 2022 09:45:11 +0100 [thread overview]
Message-ID: <20221216084511.2576786-1-primoz.fiser@norik.com> (raw)
By default, retries value is set to 0 (no retries). Set retries to more
sensible value of 3 to allow i2c core to re-attempt transfer in case of
i2c arbitration loss (i2c-imx returns -EAGAIN errno is such case).
Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
drivers/i2c/busses/i2c-imx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index cf5bacf3a488..6a5694cfe1cc 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1478,6 +1478,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
i2c_imx->adapter.dev.parent = &pdev->dev;
i2c_imx->adapter.nr = pdev->id;
i2c_imx->adapter.dev.of_node = pdev->dev.of_node;
+ i2c_imx->adapter.retries = 3;
i2c_imx->base = base;
ACPI_COMPANION_SET(&i2c_imx->adapter.dev, ACPI_COMPANION(&pdev->dev));
--
2.25.1
next reply other threads:[~2022-12-16 10:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 8:45 Primoz Fiser [this message]
2022-12-16 9:45 ` [PATCH] i2c: imx: increase retries on arbitration loss Marco Felsch
2022-12-16 10:41 ` Primoz Fiser
2022-12-16 11:02 ` Oleksij Rempel
2022-12-16 11:13 ` Uwe Kleine-König
2022-12-16 12:23 ` Primoz Fiser
2022-12-16 12:51 ` Francesco Dolcini
2022-12-28 8:01 ` Primoz Fiser
2022-12-30 14:40 ` Francesco Dolcini
2022-12-30 16:12 ` Oleksij Rempel
2022-12-30 16:47 ` Francesco Dolcini
2022-12-30 17:09 ` Francesco Dolcini
2022-12-30 17:25 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221216084511.2576786-1-primoz.fiser@norik.com \
--to=primoz.fiser@norik.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox