Re: [PATCH 01/22] gpu/drm: remove the shmobile drm driver

Laurent Pinchart
2023-01-13T07:47:00Z

Hi Christoph,

Thank you for the patch.

On Fri, Jan 13, 2023 at 07:23:18AM +0100, Christoph Hellwig wrote:
> This driver depends on ARM && ARCH_SHMOBILE, but ARCH_SHMOBILE can only be
> set for each/sh, making the driver dead code except for the COMPILE_TEST
> case.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

No objection from me.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/gpu/drm/Kconfig | 2 -
> drivers/gpu/drm/Makefile | 1 -
> drivers/gpu/drm/shmobile/Kconfig | 12 -
> drivers/gpu/drm/shmobile/Makefile | 8 -
> .../gpu/drm/shmobile/shmob_drm_backlight.c | 82 ---
> .../gpu/drm/shmobile/shmob_drm_backlight.h | 19 -
> drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 683 ------------------
> drivers/gpu/drm/shmobile/shmob_drm_crtc.h | 55 --
> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 303 --------
> drivers/gpu/drm/shmobile/shmob_drm_drv.h | 42 --
> drivers/gpu/drm/shmobile/shmob_drm_kms.c | 150 ----
> drivers/gpu/drm/shmobile/shmob_drm_kms.h | 29 -
> drivers/gpu/drm/shmobile/shmob_drm_plane.c | 261 -------
> drivers/gpu/drm/shmobile/shmob_drm_plane.h | 19 -
> drivers/gpu/drm/shmobile/shmob_drm_regs.h | 310 --------
> 15 files changed, 1976 deletions(-)
> delete mode 100644 drivers/gpu/drm/shmobile/Kconfig
> delete mode 100644 drivers/gpu/drm/shmobile/Makefile
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.c
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.h
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.h
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.c
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.h
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.c
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.h
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.c
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.h
> delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_regs.h

--
Regards,

Laurent Pinchart