Re: [PATCH v3 1/5] i2c: hpe: Add GXP SoC I2C Controller

Joel Stanley
2023-01-23T05:12:03Z

On Fri, 20 Jan 2023 at 19:04, <nick.hawkins@hpe.com> wrote:
>
> From: Nick Hawkins <nick.hawkins@hpe.com>

> +static int gxp_i2c_remove(struct platform_device *pdev)
> +{
> + struct gxp_i2c_drvdata *drvdata = platform_get_drvdata(pdev);
> +
> + disable_irq(drvdata->irq);

The i2c core calls disable_irq for us (see i2c_device_shutdown) so you
don't need that here.

In my review I wondered if you needed to do something like this:

+ regmap_update_bits(i2cg_map, GXP_I2CINTEN, 0x00000FFF, 0);

> + i2c_del_adapter(&drvdata->adapter);
> +
> + return 0;
> +}
> +