From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23AF8C05027 for ; Fri, 10 Feb 2023 08:28:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbjBJI2S (ORCPT ); Fri, 10 Feb 2023 03:28:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231424AbjBJI2S (ORCPT ); Fri, 10 Feb 2023 03:28:18 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9CA776D23 for ; Fri, 10 Feb 2023 00:28:15 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4B63267194; Fri, 10 Feb 2023 08:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676017694; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D0BqviMuHHGHaBki0gj4X4pYdQyeSpZFZ2eZT7IKNXM=; b=GOA6Jp3j2ZjivTqS39bH0jLexQfFb7TBrYxlHrgwGSH5nyIIrxo3IocYXBhPBnUwMt3mIa GWjWqUGLd3wdPjq8pK19yhPTJD0H4xa3q1XNtqNIF9vIPW9q3O31i5mZUHv+T7Umfpvcpa m2ioPUYse8CbdvlX3KJnnfPCo9yayqI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676017694; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D0BqviMuHHGHaBki0gj4X4pYdQyeSpZFZ2eZT7IKNXM=; b=VHEI1H334wR7D8OdC7sKUCXox3sMdMW4Zc4XEArAyhs0zNJFLw5Ntx3al215GbemesmIiE HTDa2bc7Y4moXdBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2411D13588; Fri, 10 Feb 2023 08:28:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rZBfBx4A5mOGCgAAMHmgww (envelope-from ); Fri, 10 Feb 2023 08:28:14 +0000 Date: Fri, 10 Feb 2023 09:28:12 +0100 From: Jean Delvare To: Heiner Kallweit Cc: linux-i2c@vger.kernel.org Subject: Re: [PATCH v2 01/10] i2c: i801: improve interrupt handler Message-ID: <20230210092812.5d71d650@endymion.delvare> In-Reply-To: References: <8db86d89-d083-2a65-76a1-6db34f433604@gmail.com> Organization: SUSE Linux X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.34; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, 19 Dec 2022 19:13:44 +0100, Heiner Kallweit wrote: > Not sure if it can happen, but better play safe: If SMBHSTSTS_BYTE_DONE > and an error flag is set, then don't trust the result and skip calling > i801_isr_byte_done(). In addition clear status bit SMBHSTSTS_BYTE_DONE > in the main interrupt handler, this allows to simplify the code a > little. > > Signed-off-by: Heiner Kallweit > --- > v2: > - change one expression for generating less binary code > --- > drivers/i2c/busses/i2c-i801.c | 25 ++++++++----------------- > 1 file changed, 8 insertions(+), 17 deletions(-) > (...) Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support