From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80977C636CD for ; Fri, 10 Feb 2023 08:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231509AbjBJIbI (ORCPT ); Fri, 10 Feb 2023 03:31:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231220AbjBJIbI (ORCPT ); Fri, 10 Feb 2023 03:31:08 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 660E0366B2 for ; Fri, 10 Feb 2023 00:31:07 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1DD9C607D2; Fri, 10 Feb 2023 08:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676017866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGp/URTxQM2KA/Z1Uj2/C63H8Hqv5GCIu9y0XzRt2YY=; b=Ko1sab6Bh5w6VufoEB5uDNLsxIWXYJptG1xhl15ECP0Y16/9GO4kJQVf37APlvbTRfJQvJ M3LAWKFfCClBQyoGYu7ku2t/yyJmsYcO51Yk5TB15y2kbLsJVzXqwxPcggXdvX8AO6BjtE UqCyzzPA+4FHdJyr7iRIDLE1e9V5K6c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676017866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGp/URTxQM2KA/Z1Uj2/C63H8Hqv5GCIu9y0XzRt2YY=; b=rDOHVxg2SR8Ilz0CghwRnpdSbvq3/Hu/xECl7oZLiMIbxNPmGIflLTdwRvvKcwDQxk3V8i iqrEYypcNyTy41Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E776113588; Fri, 10 Feb 2023 08:31:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jx7mNskA5mNTDAAAMHmgww (envelope-from ); Fri, 10 Feb 2023 08:31:05 +0000 Date: Fri, 10 Feb 2023 09:31:05 +0100 From: Jean Delvare To: Heiner Kallweit Cc: linux-i2c@vger.kernel.org Subject: Re: [PATCH v2 04/10] i2c: i801: add helper i801_set_hstadd() Message-ID: <20230210093105.7501f185@endymion.delvare> In-Reply-To: <042ba587-7428-5b44-56b3-061be22fd958@gmail.com> References: <8db86d89-d083-2a65-76a1-6db34f433604@gmail.com> <042ba587-7428-5b44-56b3-061be22fd958@gmail.com> Organization: SUSE Linux X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.34; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, 19 Dec 2022 19:16:08 +0100, Heiner Kallweit wrote: > Factor out setting SMBHSTADD to a helper. The current code makes the > assumption that constant I2C_SMBUS_READ has bit 0 set, that's not ideal. > Therefore let the new helper explicitly check for I2C_SMBUS_READ. > > Signed-off-by: Heiner Kallweit > --- > v2: > - change expressions for generating less binary code > --- > drivers/i2c/busses/i2c-i801.c | 36 ++++++++++++++++------------------- > 1 file changed, 16 insertions(+), 20 deletions(-) > (...) Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support