From: Jean Delvare <jdelvare@suse.de>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 10/10] i2c: i801: call i801_check_post() from i801_access()
Date: Wed, 15 Feb 2023 18:09:11 +0100 [thread overview]
Message-ID: <20230215180911.329f9a9d@endymion.delvare> (raw)
In-Reply-To: <0a170b74-c105-7ca3-9811-a370c81462b8@gmail.com>
Hi Heiner,
On Mon, 19 Dec 2022 19:22:42 +0100, Heiner Kallweit wrote:
> Avoid code duplication by calling i801_check_post() from i801_access().
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/i2c/busses/i2c-i801.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
> (...)
Reviewed-by: Jean Delvare <jdelvare@suse.de>
So I'm done reviewing the series. I have also tested the result,
successfully, albeit my coverage is limited.
Patches 1-4 have been committed by Wolfram already. Patches 6, 7 and 8
have minor issues. I can take care of resubmitting if you want.
My suggested changes (renaming function parameters and storing the
original value of SMBAUXCTL) are better implemented on top of that
later (if you agree with them) so as to not delay this series even
further.
Thanks for your work,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2023-02-15 17:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 18:12 [PATCH v2 00/10] i2c: i801: Series with minor improvements Heiner Kallweit
2022-12-19 18:13 ` [PATCH v2 01/10] i2c: i801: improve interrupt handler Heiner Kallweit
2023-02-10 8:28 ` Jean Delvare
2023-02-12 21:11 ` Wolfram Sang
2022-12-19 18:14 ` [PATCH v2 02/10] i2c: i801: make FEATURE_HOST_NOTIFY dependent on FEATURE_IRQ Heiner Kallweit
2023-02-10 8:29 ` Jean Delvare
2023-02-12 21:11 ` Wolfram Sang
2022-12-19 18:15 ` [PATCH v2 03/10] i2c: i801: make FEATURE_BLOCK_PROC dependent on FEATURE_BLOCK_BUFFER Heiner Kallweit
2023-02-10 8:30 ` Jean Delvare
2023-02-12 21:11 ` Wolfram Sang
2022-12-19 18:16 ` [PATCH v2 04/10] i2c: i801: add helper i801_set_hstadd() Heiner Kallweit
2023-02-10 8:31 ` Jean Delvare
2023-02-12 21:12 ` Wolfram Sang
2022-12-19 18:17 ` [PATCH v2 05/10] i2c: i801: add i801_simple_transaction(), complementing i801_block_transaction() Heiner Kallweit
2023-02-13 17:04 ` Jean Delvare
2022-12-19 18:20 ` [PATCH v2 06/10] i2c: i801: handle SMBAUXCTL_E32B in i801_block_transaction_by_block only Heiner Kallweit
2023-02-13 16:47 ` Jean Delvare
2022-12-19 18:20 ` [PATCH v2 07/10] i2c: i801: centralize configuring non-block commands in i801_simple_transaction Heiner Kallweit
2023-02-15 15:13 ` Jean Delvare
2022-12-19 18:21 ` [PATCH v2 08/10] i2c: i801: centralize configuring block commands in i801_block_transaction Heiner Kallweit
2023-02-15 15:16 ` Jean Delvare
2022-12-19 18:22 ` [PATCH v2 09/10] i2c: i801: call i801_check_pre() from i801_access() Heiner Kallweit
2022-12-19 18:22 ` [PATCH v2 10/10] i2c: i801: call i801_check_post() " Heiner Kallweit
2023-02-15 17:09 ` Jean Delvare [this message]
2023-02-15 17:16 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215180911.329f9a9d@endymion.delvare \
--to=jdelvare@suse.de \
--cc=hkallweit1@gmail.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).