From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A02FC05027 for ; Mon, 20 Feb 2023 14:41:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232198AbjBTOlK (ORCPT ); Mon, 20 Feb 2023 09:41:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232174AbjBTOlG (ORCPT ); Mon, 20 Feb 2023 09:41:06 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D83B1F907 for ; Mon, 20 Feb 2023 06:41:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1A57060EC6 for ; Mon, 20 Feb 2023 14:41:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4DF5C433D2; Mon, 20 Feb 2023 14:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676904064; bh=Ujiqv8C0y2jCD87FvS7q7OoBY1EHRwGtkNz9wutpmTQ=; h=From:To:Cc:Subject:Date:From; b=itQVYLxPGKLHQR2V9XTOd1JzSr8IzkI88mt3LriAAPQcOJS117P7hH2ppMaIITSPI t2bQtdmxKbbdyDLiFVazwUYMb3TJ9OqTrOpKWCLiCpYtU94OF2CM2LBVhrohAd50Ul iO8fD9XOKGvrdkKslCwRVQ1QHotONKk+VXd3uDheY3nV3I2irRBwRHEjmsFD0k6mkE 0NLmtrIhy2HMIy/9JzFbjsKyGxjb+Xq4K/vetYezMsgUSViuRfu1wVdyO10zpsN17v 2WJjlrAZWUeBYFeewG0YPpcptdx3v6DZr1dIsgqUBvgkwQihnvHd/FQ1Tjuz55w37J UhcsPbwhQMERw== From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: nick.hawkins@hpe.com, Wolfram Sang Subject: [PATCH] i2c: gxp: return proper error on address NACK Date: Mon, 20 Feb 2023 15:40:59 +0100 Message-Id: <20230220144059.77213-1-wsa@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org According to Documentation/i2c/fault-codes.rst, NACK after sending an address should be -ENXIO. Signed-off-by: Wolfram Sang --- Depends on: "[PATCH] i2c: gxp: remove "empty" switch statement" drivers/i2c/busses/i2c-gxp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-gxp.c b/drivers/i2c/busses/i2c-gxp.c index 352dedf6292f..fda7809e72ba 100644 --- a/drivers/i2c/busses/i2c-gxp.c +++ b/drivers/i2c/busses/i2c-gxp.c @@ -129,8 +129,10 @@ static int gxp_i2c_master_xfer(struct i2c_adapter *adapter, if (time_left == 0) return -ETIMEDOUT; - if (drvdata->state == GXP_I2C_ADDR_NACK || - drvdata->state == GXP_I2C_DATA_NACK) + if (drvdata->state == GXP_I2C_ADDR_NACK) + return -ENXIO; + + if (drvdata->state == GXP_I2C_DATA_NACK) return -EIO; return ret; -- 2.30.2