public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Wei Chen <harperchen1110@gmail.com>
To: linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Wei Chen <harperchen1110@gmail.com>
Subject: [PATCH] i2c: xgene-slimpro: Fix out-of-bounds bug in xgene_slimpro_i2c_xfer()
Date: Tue, 14 Mar 2023 13:57:34 +0000	[thread overview]
Message-ID: <20230314135734.2792944-1-harperchen1110@gmail.com> (raw)

The data->block[0] variable comes from user and is a number between
0-255. Without proper check, the variable may be very large to cause
an out-of-bounds when performing memcpy in slimpro_i2c_blkwr.

Fix this bug by checking the value of data->block[0].

Signed-off-by: Wei Chen <harperchen1110@gmail.com>
---
 drivers/i2c/busses/i2c-xgene-slimpro.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index 63259b3ea5ab..bc9a3e7e0c96 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -391,6 +391,10 @@ static int xgene_slimpro_i2c_xfer(struct i2c_adapter *adap, u16 addr,
 						&data->block[0]);
 
 		} else {
+
+			if (data->block[0] + 1 > I2C_SMBUS_BLOCK_MAX)
+				return -EINVAL;
+
 			ret = slimpro_i2c_blkwr(ctx, addr, command,
 						SMBUS_CMD_LEN,
 						SLIMPRO_IIC_SMB_PROTOCOL,
@@ -408,6 +412,10 @@ static int xgene_slimpro_i2c_xfer(struct i2c_adapter *adap, u16 addr,
 						IIC_SMB_WITHOUT_DATA_LEN,
 						&data->block[1]);
 		} else {
+
+			if (data->block[0] > I2C_SMBUS_BLOCK_MAX)
+				return -EINVAL;
+
 			ret = slimpro_i2c_blkwr(ctx, addr, command,
 						SMBUS_CMD_LEN,
 						SLIMPRO_IIC_I2C_PROTOCOL,
-- 
2.25.1


             reply	other threads:[~2023-03-14 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 13:57 Wei Chen [this message]
2023-03-14 14:10 ` [PATCH] i2c: xgene-slimpro: Fix out-of-bounds bug in xgene_slimpro_i2c_xfer() Andi Shyti
2023-03-14 15:43   ` [PATCH v2] " Wei Chen
2023-03-14 15:57     ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314135734.2792944-1-harperchen1110@gmail.com \
    --to=harperchen1110@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox