From: Mark Hasemeyer <markhas@chromium.org>
To: markhas@chromium.org
Cc: Felix.Held@amd.com, Rijo-john.Thomas@amd.com,
Thomas.Lendacky@amd.com, andriy.shevchenko@linux.intel.com,
gjb@semihalf.com, herbert@gondor.apana.org.au,
jarkko.nikula@linux.intel.com, jsd@semihalf.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
mario.limonciello@amd.com, mika.westerberg@linux.intel.com
Subject: [PATCH v4 8/8] i2c: designware: Add doorbell support for Skyrim
Date: Mon, 20 Mar 2023 13:31:24 -0600 [thread overview]
Message-ID: <20230320193124.55807-1-markhas@chromium.org> (raw)
In-Reply-To: <20230320190407.51252-1-markhas@chromium.org>
> +static int psp_send_i2c_req_skyrim(enum psp_i2c_req_type i2c_req_type)
> +{
> + return psp_ring_platform_doorbell(i2c_req_type);
> +}
Should this function retry acquiring the I2C bus while it is busy? Similar to
how the cezanne variant works. Also wondering if the function should be named
psp_send_i2c_req_mendocino for consistency.
Sorry about the repost, the quoted code wasn't included originally.
next prev parent reply other threads:[~2023-03-20 19:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 21:19 [PATCH v4 0/8] Export platform features from ccp driver Mario Limonciello
2023-03-10 21:19 ` [PATCH v4 2/8] crypto: ccp: Add a header for multiple drivers to use `__psp_pa` Mario Limonciello
2023-03-10 21:19 ` [PATCH v4 3/8] crypto: ccp: Move some PSP mailbox bit definitions into common header Mario Limonciello
2023-03-13 10:30 ` Jarkko Nikula
2023-03-10 21:19 ` [PATCH v4 6/8] i2c: designware: Use PCI PSP driver for communication Mario Limonciello
2023-03-13 10:30 ` Jarkko Nikula
2023-03-15 10:28 ` Grzegorz Bernacki
2023-03-10 21:19 ` [PATCH v4 8/8] i2c: designware: Add doorbell support for Skyrim Mario Limonciello
2023-03-13 10:29 ` Jarkko Nikula
2023-03-13 11:34 ` Andy Shevchenko
2023-03-20 19:04 ` Mark Hasemeyer
2023-03-20 19:31 ` Mark Hasemeyer [this message]
2023-03-17 3:26 ` [PATCH v4 0/8] Export platform features from ccp driver Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320193124.55807-1-markhas@chromium.org \
--to=markhas@chromium.org \
--cc=Felix.Held@amd.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gjb@semihalf.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).