Re: [PATCH v6 1/6] usb: Add support for Intel LJCA device

Greg Kroah-Hartman
2023-03-23T18:05:34Z

On Fri, Mar 24, 2023 at 01:21:08AM +0800, Ye Xiang wrote:
> +config USB_LJCA
> + tristate "Intel La Jolla Cove Adapter support"
> + select AUXILIARY_BUS
> + depends on USB
> + help
> + This adds support for Intel La Jolla Cove USB-I2C/SPI/GPIO
> + Master Adapter (LJCA). Additional drivers such as I2C_LJCA,
> + GPIO_LJCA and SPI_LJCA must be enabled in order to use the
> + functionality of the device.
> +
> + This driver can also be built as a module. If so, the module
> + will be called ljca.

That's a very generic name for a USB driver, why not "usb_ljca"?

> +struct ljca_dev {
> + struct usb_device *udev;

You didn't remove this like you said you would :(