RE: [PATCH v7 2/2] i2c: aspeed: support ast2600 i2c new register mode driver

Ryan Chen
2023-03-29T01:07:01Z

Hello Andi,

> -----Original Message-----
> From: Andi Shyti <andi.shyti@kernel.org>
> Sent: Tuesday, March 28, 2023 9:12 PM
> To: Ryan Chen <ryan_chen@aspeedtech.com>
> Cc: jk@codeconstruct.com.au; openbmc@lists.ozlabs.org;
> linux-arm-kernel@lists.infradead.org; linux-i2c@vger.kernel.org; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; Andrew
> Jeffery <andrew@aj.id.au>; Linus Walleij <linus.walleij@linaro.org>;
> linux-aspeed@lists.ozlabs.org
> Subject: Re: [PATCH v7 2/2] i2c: aspeed: support ast2600 i2c new register mode
> driver
>
> Hi Ryan,
>
> [...]
>
> > + ret = of_property_read_u32(dev->of_node,
> > + "i2c-scl-clk-low-timeout-us",
> > + &i2c_bus->timeout);
>
> in your v6 patch this was a boolean value. If you need to keep it boolean you
> have the "i2c-scl-has-clk-low-timeout".

Thank your remind, I will keep " i2c-scl-clk-low-timeout-us", if property is empty, will disable it.
If not, will enable the timeout. It is ok for me.

>
> > + if (ret < 0) {
> > + i2c_bus->timeout = 0;
> > + } else {
> > + /* i2c timeout counter: use base clk4 1Mhz
> > + * per unit: 1/(1000/4096) = 4096us
> > + */
> > + i2c_bus->timeout /= 4096;
> > + }
>
> Can you please run checkpatch.pl before sending the patch?
>
> [...]
>
> > + dev_info(dev, "%s [%d]: adapter [%d khz] mode [%d]\n",
> > + dev->of_node->name, i2c_bus->adap.nr, i2c_bus->bus_frequency /
> 1000,
> > + i2c_bus->mode);
> > +
> > + return 0;
> > +
> > + return ret;
>
> can you also please do some cleanups before sending the patch?
Sorry, will update these two. And send next patch.

Best Regards,
Ryan.