From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71188C7EE25 for ; Mon, 8 May 2023 21:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233705AbjEHVAs (ORCPT ); Mon, 8 May 2023 17:00:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233813AbjEHVAY (ORCPT ); Mon, 8 May 2023 17:00:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D22166E98 for ; Mon, 8 May 2023 14:00:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6963962FA7 for ; Mon, 8 May 2023 21:00:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DC8EC433D2; Mon, 8 May 2023 21:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683579621; bh=HuZXZyIsyyrsaaFo7CxO+2hnXlQ/3Nhe97ni5qf0luo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AA/lkaDC4XXGg9p0Imm/N+MBsdmMH/iaoaQcNKv0l3zKmK6MZwG+8l4wNVTIcWLAe uJZ49qJmP+m1ruVQ5mM7BJJJMnPq4wcDBcuqjwCBaXri6Q405FseOcrTLmi+2DGSU0 8BFNlPhdGO10NFLL5XmwEFuFktkgkRKjTEpOeGiQpS4+Tow8NANUBkrl4gNyE4827k XpoOS864vI4nLM1fF4easuILyqne1tSJei6h/OZNx/S3uPj/kHQCmXLZyZsH7RuRwD btlUcMfPgQ+7WTcl8cTlDvWm3lwIMA0B5cZ4EervFlFQ5vKVcjqlF8QMXYzx4Nq+pr dUTys+LEvfJXw== Date: Mon, 8 May 2023 22:00:17 +0100 From: Conor Dooley To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Conor Dooley , Daire McNamara , Wolfram Sang , linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 37/89] i2c: microchip-corei2c: Convert to platform remove callback returning void Message-ID: <20230508-cottage-senator-e4882fbe9010@spud> References: <20230508205306.1474415-1-u.kleine-koenig@pengutronix.de> <20230508205306.1474415-38-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lOjmbblZE3LZ+1uX" Content-Disposition: inline In-Reply-To: <20230508205306.1474415-38-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --lOjmbblZE3LZ+1uX Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 08, 2023 at 10:52:14PM +0200, Uwe Kleine-K=F6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. >=20 > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. >=20 > Signed-off-by: Uwe Kleine-K=F6nig Reviewed-by: Conor Dooley Thanks, Conor. --lOjmbblZE3LZ+1uX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZFli4QAKCRB4tDGHoIJi 0mQyAP42uKbl045YUAeaLFX1GnoxoLfsqEPIBLLm24QuRYsibgEA0f9L0vL03xi4 RnHjvn+HLIB4qXCKk4B76QCeA29TbAo= =VzIV -----END PGP SIGNATURE----- --lOjmbblZE3LZ+1uX--