Re: [PATCH v2 2/2] dt-bindings: i2c: brcm,kona-i2c: convert to YAML

Stanislav Jakubek
2023-04-26T17:24:13Z

On Mon, Apr 24, 2023 at 08:28:08AM -0500, Rob Herring wrote:
>
> On Sun, 23 Apr 2023 14:40:18 +0200, Stanislav Jakubek wrote:
> > Convert Broadcom Kona family I2C bindings to DT schema.
> >
> > Changes during conversion:
> > - add used, but previously undocumented SoC-specific compatibles
> > - drop references to SoCs that are not upstream
> > - add supported clock frequencies according to the Linux driver [1]
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/i2c/busses/i2c-bcm-kona.c#n731
> >
> > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> > ---
> > Changes in v2:
> > - add missing arm-gic.h include
> > - fix indentation to 4 spaces
> >
> > .../devicetree/bindings/i2c/brcm,kona-i2c.txt | 35 -----------
> > .../bindings/i2c/brcm,kona-i2c.yaml | 59 +++++++++++++++++++
> > 2 files changed, 59 insertions(+), 35 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/i2c/brcm,kona-i2c.txt
> > create mode 100644 Documentation/devicetree/bindings/i2c/brcm,kona-i2c.yaml
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/72ba28004afb733224f7294a146fc2a6a5a834a7.1682252615.git.stano.jakubek@gmail.com
>
>
> i2c@16000: compatible:0: 'brcm,kona-i2c' is not one of ['brcm,bcm11351-i2c', 'brcm,bcm21664-i2c', 'brcm,bcm23550-i2c']
> arch/arm/boot/dts/bcm23550-sparrow.dtb
>
> i2c@16000: compatible: ['brcm,kona-i2c'] is too short
> arch/arm/boot/dts/bcm23550-sparrow.dtb
>
> i2c@17000: compatible:0: 'brcm,kona-i2c' is not one of ['brcm,bcm11351-i2c', 'brcm,bcm21664-i2c', 'brcm,bcm23550-i2c']
> arch/arm/boot/dts/bcm23550-sparrow.dtb
>
> i2c@17000: compatible: ['brcm,kona-i2c'] is too short
> arch/arm/boot/dts/bcm23550-sparrow.dtb
>
> i2c@18000: compatible:0: 'brcm,kona-i2c' is not one of ['brcm,bcm11351-i2c', 'brcm,bcm21664-i2c', 'brcm,bcm23550-i2c']
> arch/arm/boot/dts/bcm23550-sparrow.dtb
>
> i2c@18000: compatible: ['brcm,kona-i2c'] is too short
> arch/arm/boot/dts/bcm23550-sparrow.dtb
>
> i2c@1c000: compatible:0: 'brcm,kona-i2c' is not one of ['brcm,bcm11351-i2c', 'brcm,bcm21664-i2c', 'brcm,bcm23550-i2c']
> arch/arm/boot/dts/bcm23550-sparrow.dtb
>
> i2c@1c000: compatible: ['brcm,kona-i2c'] is too short
> arch/arm/boot/dts/bcm23550-sparrow.dtb
>

These warnings are fixed by the first patch in the series.
Maybe it didn't apply?

Regards,
Stanislav