From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: <linux-i2c@vger.kernel.org>, Wolfram Sang <wsa@kernel.org>,
Niyas Sait <niyas.sait@linaro.org>,
Klaus Jensen <its@irrelevant.dk>,
Andy Shevchenko <andy@kernel.org>, <linux-acpi@vger.kernel.org>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
Shesha Bhushan Sreenivasamurthy <sheshas@marvell.com>,
<linux-cxl@vger.kernel.org>, <linuxarm@huawei.com>,
"Viacheslav A . Dubeyko" <viacheslav.dubeyko@bytedance.com>
Subject: Re: [RFC PATCH v2 2/6] i2c: aspeed: Use platform_get_irq() instead of opencoding
Date: Wed, 31 May 2023 10:36:00 +0100 [thread overview]
Message-ID: <20230531103600.00006551@Huawei.com> (raw)
In-Reply-To: <CAHp75VdNXtnorvx+aFhkkQZdgArVLuU_0-W-OKUyyarntt6vwA@mail.gmail.com>
On Tue, 30 May 2023 22:45:30 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Tue, May 30, 2023 at 5:57 PM Jonathan Cameron
> <Jonathan.Cameron@huawei.com> wrote:
> >
> > A cleanup in it's own right.
>
> its ?
Pah. English - a language that I can't write in despite it being
my native tongue ;)
>
> > This has the handy side effect of working for ACPI FW as well
> > (unlike fwnode_irq_get() which works for ARM64 but not x86 ACPI)
>
> ...
>
> > #include <linux/of_address.h>
>
> > #include <linux/of_platform.h>
>
> With your commit message I'm wondering why these are still there. Do
> we have some OF calls that are optional and do not affect
> functionality (in ACPI case)?
>
>
next prev parent reply other threads:[~2023-05-31 9:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 14:55 [RFC PATCH v2 0/6] i2c: Enabling use of aspeed-i2c with ACPI Jonathan Cameron
2023-05-30 14:55 ` [RFC PATCH v2 1/6] i2c: acpi: set slave mode flag Jonathan Cameron
2023-05-30 14:55 ` [RFC PATCH v2 2/6] i2c: aspeed: Use platform_get_irq() instead of opencoding Jonathan Cameron
2023-05-30 19:45 ` Andy Shevchenko
2023-05-31 9:36 ` Jonathan Cameron [this message]
2023-05-30 14:55 ` [RFC PATCH v2 3/6] i2c: aspeed: Don't report error when optional dt bus-frequency not supplied Jonathan Cameron
2023-05-30 19:47 ` Andy Shevchenko
2023-05-30 14:55 ` [RFC PATCH v2 4/6] i2c: aspeed: switch to generic fw properties Jonathan Cameron
2023-05-30 19:50 ` Andy Shevchenko
2023-05-31 10:46 ` Jonathan Cameron
2023-05-30 14:56 ` [RFC PATCH v2 5/6] i2c: aspeed: Set the fwnode for the adap->dev Jonathan Cameron
2023-05-30 19:51 ` Andy Shevchenko
2023-05-30 14:56 ` [RFC PATCH v2 6/6] HACK: i2c: aspeed: Comment clock out and make reset optional Jonathan Cameron
2023-05-30 19:59 ` Andy Shevchenko
2023-05-31 9:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531103600.00006551@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=its@irrelevant.dk \
--cc=jk@codeconstruct.com.au \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=matt@codeconstruct.com.au \
--cc=niyas.sait@linaro.org \
--cc=sheshas@marvell.com \
--cc=viacheslav.dubeyko@bytedance.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).