From: Andi Shyti <andi.shyti@kernel.org>
To: "wsa@kernel.org" <wsa@kernel.org>,
Robert Hancock <robert.hancock@calian.com>,
"michal.simek@amd.com" <michal.simek@amd.com>,
"shubhraj@xilinx.com" <shubhraj@xilinx.com>,
"marex@denx.de" <marex@denx.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: xiic: Don't try to handle more interrupt events after error
Date: Fri, 9 Jun 2023 23:25:52 +0200 [thread overview]
Message-ID: <20230609212552.5o6aopv7iicej3kn@intel.intel> (raw)
In-Reply-To: <ZINGGmRLYEQ+NfkI@shikoro>
Hi Wolfram,
On Fri, Jun 09, 2023 at 05:32:42PM +0200, wsa@kernel.org wrote:
>
> > I think the patch is correct and I will ack it:
> >
> > Acked-by: Andi Shyti <andi.shyti@kernel.org>
> >
> > I think, though, that this needs a proper fix and testing, in
> > order to cover all the possible combinations. The scenario you
> > highlighted is indeed one, but not only, potential situation that
> > could arise.
> >
> > Can I just ask you to write a bit more in the comment to
> > highlight the possible failure?
>
> I tend to apply it to for-current because it improves the situation.
> Further improvements could be made incrementally? D'accord everyone?
>
OK with that!
Thanks,
Andi
next prev parent reply other threads:[~2023-06-09 21:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 18:25 [PATCH] i2c: xiic: Don't try to handle more interrupt events after error Robert Hancock
2023-06-06 19:24 ` Andi Shyti
2023-06-06 19:40 ` Robert Hancock
2023-06-06 21:20 ` Andi Shyti
2023-06-09 15:32 ` wsa
2023-06-09 21:25 ` Andi Shyti [this message]
2023-06-27 16:13 ` Robert Hancock
2023-06-27 21:25 ` wsa
2023-07-06 19:33 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609212552.5o6aopv7iicej3kn@intel.intel \
--to=andi.shyti@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=michal.simek@amd.com \
--cc=robert.hancock@calian.com \
--cc=shubhraj@xilinx.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox