Re: [PATCH] i2c: sun6i-p2wi: Fix an error message in probe()

Andi Shyti
2023-06-27T11:59:36Z

Hi Dan,

On Tue, Jun 27, 2023 at 10:12:36AM +0300, Dan Carpenter wrote:
> The "ret" variable is uninitialized. It was the "p2wi->rstc" variable
> that was intended. We can also use the %pe string format to print the
> error code name instead of just the number.
>
> Fixes: 75ff8a340a81 ("i2c: sun6i-p2wi: Use devm_clk_get_enabled()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/i2c/busses/i2c-sun6i-p2wi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c
> index ad8270cdbd3e..fa6020dced59 100644
> --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c
> +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c
> @@ -250,7 +250,8 @@ static int p2wi_probe(struct platform_device *pdev)
>
> p2wi->rstc = devm_reset_control_get_exclusive(dev, NULL);
> if (IS_ERR(p2wi->rstc)) {
> - dev_err(dev, "failed to retrieve reset controller: %d\n", ret);
> + dev_err(dev, "failed to retrieve reset controller: %pe\n",
> + p2wi->rstc);

Yes, good catch! Thanks! But I think we want to print the error
value here, so I think it should be:

- dev_err(dev, "failed to retrieve reset controller: %d\n", ret);
+ dev_err(dev, "failed to retrieve reset controller: %d\n",
+ PTR_ERR(p2wi->rstc));

Andi

> return PTR_ERR(p2wi->rstc);
> }
>
> --
> 2.39.2
>