public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Wolfram Sang <wsa@kernel.org>,
	kernel@pengutronix.de,
	Javier Martinez Canillas <javierm@redhat.com>,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c: Update documentation to use .probe() again
Date: Tue, 27 Jun 2023 13:44:29 +0200	[thread overview]
Message-ID: <20230627134429.50e2ab52@endymion.delvare> (raw)
In-Reply-To: <20230627064522.593332-1-u.kleine-koenig@pengutronix.de>

On Tue, 27 Jun 2023 08:45:22 +0200, Uwe Kleine-König wrote:
> Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id
> parameter") .probe() is the recommended callback to implement (again).
> Reflect this in the documentation and don't mention .probe_new() any
> more.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> changes since (implicit) v1 sent a moment ago:
> 
>  - Fix whitespace. My editor seems to be configured to expand tabs to
>    spaces in rst files, but that's inconsitent with the tab style used
>    in that file.
> 
> Best regards
> Uwe
> 
>  Documentation/i2c/writing-clients.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/i2c/writing-clients.rst b/Documentation/i2c/writing-clients.rst
> index b7d3ae7458f8..41ddc10f1ac7 100644
> --- a/Documentation/i2c/writing-clients.rst
> +++ b/Documentation/i2c/writing-clients.rst
> @@ -46,7 +46,7 @@ driver model device node, and its I2C address.
>  	},
>  
>  	.id_table	= foo_idtable,
> -	.probe_new	= foo_probe,
> +	.probe		= foo_probe,
>  	.remove		= foo_remove,
>  	/* if device autodetection is needed: */
>  	.class		= I2C_CLASS_SOMETHING,
> 
> base-commit: 6995e2de6891c724bfeb2db33d7b87775f913ad1

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support

  reply	other threads:[~2023-06-27 11:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27  6:45 [PATCH v2] i2c: Update documentation to use .probe() again Uwe Kleine-König
2023-06-27 11:44 ` Jean Delvare [this message]
2023-06-27 12:16 ` Javier Martinez Canillas
2023-08-05 16:54 ` Andi Shyti
2023-08-14 16:15 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230627134429.50e2ab52@endymion.delvare \
    --to=jdelvare@suse.de \
    --cc=javierm@redhat.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox