From: Akhil R <akhilrajeev@nvidia.com>
To: <thierry.reding@gmail.com>
Cc: <andi.shyti@kernel.org>, <jonathanh@nvidia.com>,
<linux-i2c@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<wsa@kernel.org>, <akhilrajeev@nvidia.com>,
<sdonthineni@nvidia.com>
Subject: Re: [PATCH v2] i2c: tegra: Fix failure during probe deferral cleanup
Date: Thu, 20 Jul 2023 21:12:43 +0530 [thread overview]
Message-ID: <20230720154243.12779-1-akhilrajeev@nvidia.com> (raw)
In-Reply-To: <20230707132619.2998382-1-thierry.reding@gmail.com>
>If the driver fails to obtain a DMA channel, it will initiate cleanup
>and try to release the DMA channel that couldn't be retrieved. This
>will cause a crash because the cleanup will try to dereference an
>ERR_PTR()- encoded error code.
>
>However, there's nothing to clean up at this point yet, so we can avoid
>this by simply resetting the DMA channel to NULL instead of storing the
>error code.
>
>Fixes: fcc8a89a1c83 ("i2c: tegra: Share same DMA channel for RX and
>TX")
>Signed-off-by: Thierry Reding mailto:treding@nvidia.com
This fixed the crash issue seen when there is no dmas property in
the device tree.
Resending this with the correct headers to get it recorded by
patchwork.
Tested-by: Akhil R <akhilrajeev@nvidia.com>
next prev parent reply other threads:[~2023-07-20 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 13:26 [PATCH v2] i2c: tegra: Fix failure during probe deferral cleanup Thierry Reding
2023-07-20 15:42 ` Akhil R [this message]
2023-07-25 16:25 ` Thierry Reding
2023-07-25 21:34 ` Andi Shyti
2023-07-27 15:05 ` Thierry Reding
2023-07-27 19:57 ` Andi Shyti
2023-08-14 13:34 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2023-07-17 17:15 Akhil R
2023-07-17 17:25 ` Shanker Donthineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720154243.12779-1-akhilrajeev@nvidia.com \
--to=akhilrajeev@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sdonthineni@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox