From: carlos.song@nxp.com
To: andi.shyti@kernel.org, aisheng.dong@nxp.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com
Cc: carlos.song@nxp.com, xiaoning.wang@nxp.com, haibo.chen@nxp.com,
linux-imx@nxp.com, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/3] i2c: imx-lpi2c: directly return ISR when detect a NACK
Date: Mon, 24 Jul 2023 18:55:44 +0800 [thread overview]
Message-ID: <20230724105546.1964059-1-carlos.song@nxp.com> (raw)
From: Gao Pan <pandy.gao@nxp.com>
A NACK flag in ISR means i2c bus error. In such codition,
there is no need to do read/write operation. It's better
to return ISR directly and then stop i2c transfer.
Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
Signed-off-by: Gao Pan <pandy.gao@nxp.com>
Signed-off-by: Carlos Song <carlos.song@nxp.com>
---
drivers/i2c/busses/i2c-imx-lpi2c.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index c3287c887c6f..158de0b7f030 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -514,15 +514,14 @@ static irqreturn_t lpi2c_imx_isr(int irq, void *dev_id)
temp = readl(lpi2c_imx->base + LPI2C_MSR);
temp &= enabled;
- if (temp & MSR_RDF)
+ if (temp & MSR_NDF) {
+ complete(&lpi2c_imx->complete);
+ return IRQ_HANDLED;
+ } else if (temp & MSR_RDF)
lpi2c_imx_read_rxfifo(lpi2c_imx);
-
- if (temp & MSR_TDF)
+ else if (temp & MSR_TDF)
lpi2c_imx_write_txfifo(lpi2c_imx);
- if (temp & MSR_NDF)
- complete(&lpi2c_imx->complete);
-
return IRQ_HANDLED;
}
--
2.34.1
next reply other threads:[~2023-07-24 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 10:55 carlos.song [this message]
2023-07-24 10:55 ` [PATCH v2 2/3] i2c: imx-lpi2c: add bus recovery feature carlos.song
2023-07-26 14:11 ` Andi Shyti
2023-07-28 9:48 ` Carlos Song
2023-07-24 10:55 ` [PATCH v2 3/3] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work carlos.song
2023-07-24 12:38 ` Fabio Estevam
2023-07-25 1:59 ` [EXT] " Carlos Song
2023-07-25 23:55 ` [PATCH v2 1/3] i2c: imx-lpi2c: directly return ISR when detect a NACK Andi Shyti
2023-07-26 7:58 ` [EXT] " Carlos Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724105546.1964059-1-carlos.song@nxp.com \
--to=carlos.song@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andi.shyti@kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox