From: Andi Shyti <andi.shyti@kernel.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH -next] i2c: s3c2410: Remove redundant dev_err()
Date: Wed, 26 Jul 2023 16:46:19 +0200 [thread overview]
Message-ID: <20230726144619.qo3ttjjmjvliwz23@intel.intel> (raw)
In-Reply-To: <20230726174226.2480552-1-ruanjinjie@huawei.com>
Hi Ruan,
On Wed, Jul 26, 2023 at 05:42:26PM +0000, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Correct!
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
next prev parent reply other threads:[~2023-07-26 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 17:42 [PATCH -next] i2c: s3c2410: Remove redundant dev_err() Ruan Jinjie
2023-07-26 14:46 ` Andi Shyti [this message]
2023-08-02 20:10 ` Andi Shyti
2023-08-14 15:05 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726144619.qo3ttjjmjvliwz23@intel.intel \
--to=andi.shyti@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox